fix(seer-explorer): Memoize repoNames to stabilize useMemo dependencies#111984
Draft
fix(seer-explorer): Memoize repoNames to stabilize useMemo dependencies#111984
Conversation
Object.keys(repoStats) was called at function body level, producing a new array reference on every render. This defeated three downstream useMemo hooks that listed repoNames in their dependency arrays, causing them to recompute unnecessarily on every render. Wrap the derivation in its own useMemo keyed on repoStats so the reference stays stable. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Object.keys(repoStats)inusePRWidgetDatawas called at function bodylevel, producing a new array reference on every render. This defeated three
downstream
useMemohooks that listedrepoNamesin their dependencyarrays, causing them to recompute on every render regardless of whether the
underlying data changed.
Wraps the derivation in its own
useMemokeyed onrepoStatsso thereference stays stable across rerenders.
Adds a test that verifies memoized values remain referentially identical
across rerenders with unchanged inputs — the test fails without the fix.