Skip to content

ref(assisted-query): cleanup redundant flag checks for polling variant#112035

Merged
aliu39 merged 1 commit into
masterfrom
aliu/cleanup-poll
Apr 1, 2026
Merged

ref(assisted-query): cleanup redundant flag checks for polling variant#112035
aliu39 merged 1 commit into
masterfrom
aliu/cleanup-poll

Conversation

@aliu39
Copy link
Copy Markdown
Member

@aliu39 aliu39 commented Apr 1, 2026

For logs/discover/issues, enableAiSearch is = this flag being on. The combobox components are never shown unless enableAiSearch (condition right above usePollingEndpoint), so the !usePollingEndpoint is a dead branch. In general this FF is a killswitch for the whole ai search feature, not a polling variant. The polling toggle only works for spans, the only dataset that has a sync implementation

@aliu39 aliu39 requested review from a team as code owners April 1, 2026 19:43
@github-actions github-actions Bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 1, 2026
@aliu39 aliu39 merged commit f059ef7 into master Apr 1, 2026
75 checks passed
@aliu39 aliu39 deleted the aliu/cleanup-poll branch April 1, 2026 20:09
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 17, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants