ref(preprod): Decouple approval creation from status check client lookup#112037
Closed
NicoHinderling wants to merge 1 commit into03-31-feat_preprod_approval_frontendfrom
Conversation
This was referenced Apr 1, 2026
github-actions
bot
added
the
Scope: Backend
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Contributor
Author
|
decided to move this logic directly into #111975 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Decouples
PreprodComparisonApproval(NEEDS_APPROVAL) record creation from the status check client/repository lookup in the snapshot status check task.Previously,
get_status_check_client()was called early in the task and returned early if no repository or integration was configured. This meant the approval creation logic (further down) was never reached — so snapshots with changes would never enter the "pending approval" state unless a GitHub integration was set up.Now the approval records are created before the status check client lookup, so the approval workflow functions independently of whether a VCS integration is configured.