Skip to content

ref(seer): Refactor hooks related to the preferred agent option #112042

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryan953 merged 8 commits into from
Apr 3, 2026
Merged

ref(seer): Refactor hooks related to the preferred agent option #112042

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
421f99a
ref(seer): Refactor hooks related to the preferred agent option
ryan953 Apr 1, 2026
4e4828e
all the overrides of the query results
ryan953 Apr 1, 2026
09d94ad
review comments
ryan953 Apr 2, 2026
311b9ae
improve getPreferredAgentMutationOptions test
ryan953 Apr 2, 2026
16e312e
handle non 429 errors when bulk updating
ryan953 Apr 2, 2026
747b6e8
make sure to set org before tests run, and prevent `undefined` agent …
ryan953 Apr 2, 2026
e1c4291
fix test
ryan953 Apr 2, 2026
c552759
implement isValueEqual on the Select
ryan953 Apr 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions static/app/views/settings/seer/overview/autofixOverviewSection.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,9 +417,13 @@ describe('autofixOverviewSection', () => {
it('shows "No projects found" when there are no projects', async () => {
renderSection([], {projects: []});

// Each form section renders this text, so use findAllByText
const messages = await screen.findAllByText('No projects found');
expect(messages.length).toBeGreaterThanOrEqual(2);
// Each form section renders this text; AgentNameForm only shows it after
// the integrations query resolves, so use waitFor to retry until both appear
await waitFor(() => {
expect(screen.getAllByText('No projects found').length).toBeGreaterThanOrEqual(
2
);
});
});

it('shows "Your existing project uses Seer Agent" when 1 project uses preferred agent', async () => {
Expand Down
163 changes: 70 additions & 93 deletions static/app/views/settings/seer/overview/autofixOverviewSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,21 +15,24 @@ import {
bulkAutofixAutomationSettingsInfiniteOptions,
type AutofixAutomationSettings,
} from 'sentry/components/events/autofix/preferences/hooks/useBulkAutofixAutomationSettings';
import {organizationIntegrationsCodingAgents} from 'sentry/components/events/autofix/useAutofix';
import {type CodingAgentIntegration} from 'sentry/components/events/autofix/useAutofix';
import {Placeholder} from 'sentry/components/placeholder';
import {IconSettings} from 'sentry/icons';
import {t, tct, tn} from 'sentry/locale';
import type {Organization} from 'sentry/types/organization';
import type {Project} from 'sentry/types/project';
import {useFetchAllPages} from 'sentry/utils/api/apiFetch';
import {fetchMutation, useQuery} from 'sentry/utils/queryClient';
import {fetchMutation} from 'sentry/utils/queryClient';
import {useInfiniteQuery} from 'sentry/utils/queryClient';
import {useOrganization} from 'sentry/utils/useOrganization';
import {useProjects} from 'sentry/utils/useProjects';
import {
useAgentOptions,
useBulkMutateCreatePr,
getPreferredAgentMutationOptions,
useFetchPreferredAgent,
useFetchPreferredAgentOptions,
useBulkMutateSelectedAgent,
} from 'sentry/views/settings/seer/seerAgentHooks';
} from 'sentry/views/settings/seer/overview/utils/seerPreferredAgent';
import {useBulkMutateCreatePr} from 'sentry/views/settings/seer/seerAgentHooks';

export function useAutofixOverviewData() {
const organization = useOrganization();
Expand Down Expand Up @@ -81,6 +84,9 @@ export function AutofixOverviewSection({canWrite, data, isPending, organization}
const {projects} = useProjects();

const {projectsWithPreferredAgent = [], projectsWithCreatePr = []} = data ?? {};
const projectsIdsWithPreferredAgent = new Set(
projectsWithPreferredAgent.map(s => s.projectId)
);

const [isBulkMutatingAgent, setIsBulkMutatingAgent] = useState(false);
const [isBulkMutatingCreatePr, setIsBulkMutatingCreatePr] = useState(false);
Expand Down Expand Up @@ -108,7 +114,7 @@ export function AutofixOverviewSection({canWrite, data, isPending, organization}
isBulkMutatingCreatePr={isBulkMutatingCreatePr}
organization={organization}
projects={projects}
projectsWithPreferredAgent={projectsWithPreferredAgent}
projectsIdsWithPreferredAgent={projectsIdsWithPreferredAgent}
/>

<CreatePrForm
Expand All @@ -133,82 +139,38 @@ function AgentNameForm({
isBulkMutatingCreatePr,
organization,
projects,
projectsWithPreferredAgent,
projectsIdsWithPreferredAgent,
}: {
canWrite: boolean;
isBulkMutatingAgent: boolean;
isBulkMutatingCreatePr: boolean;
isPending: boolean;
organization: Organization;
projects: Project[];
projectsWithPreferredAgent: AutofixAutomationSettings[];
projectsIdsWithPreferredAgent: Set<string>;
setIsBulkMutatingAgent: (value: boolean) => void;
}) {
const {data: integrations} = useQuery(
organizationIntegrationsCodingAgents(organization)
);
const rawAgentOptions = useAgentOptions({
integrations: integrations?.integrations ?? [],
}).filter(option => option.value !== 'none');
const codingAgentOptions = rawAgentOptions.map(option => ({
value: option.value === 'seer' ? 'seer' : String(option.value.id),
label: option.label,
}));

const codingAgentMutationOpts = mutationOptions({
mutationFn: ({agentId}: {agentId: string}) => {
return fetchMutation<Organization>({
method: 'PUT',
url: `/organizations/${organization.slug}/`,
Comment thread
cursor[bot] marked this conversation as resolved.
data:
agentId === 'seer'
? {
defaultCodingAgent: agentId,
defaultCodingAgentIntegrationId: null,
}
: {
defaultCodingAgent: rawAgentOptions
.filter(option => option.value !== 'seer')
.find(option => option.value.id === agentId)?.value.provider,
defaultCodingAgentIntegrationId: agentId,
},
});
},
onSuccess: updateOrganization,
const preferredAgent = useFetchPreferredAgent({organization});
const codingAgentSelectOptions = useFetchPreferredAgentOptions({organization});
const codingAgentMutationOptions = getPreferredAgentMutationOptions({organization});
const bulkMutateSelectedAgent = useBulkMutateSelectedAgent({
projects: projects.filter(p => !projectsIdsWithPreferredAgent.has(p.id)),
});

const preferredAgentValue = organization.defaultCodingAgentIntegrationId
? String(organization.defaultCodingAgentIntegrationId)
: organization.defaultCodingAgent
? organization.defaultCodingAgent
: 'seer';

const preferredAgentLabel = codingAgentOptions.find(
option => option.value === preferredAgentValue
const preferredAgentLabel = codingAgentSelectOptions.data?.find(
o => o.value === preferredAgent.data
)?.label;

const preferredAgentIntegration =
preferredAgentValue === 'seer'
? 'seer'
: rawAgentOptions
.filter(option => option.value !== 'seer')
.find(option => option.value.id === preferredAgentValue)?.value;

const preferredAgentProjectIds = new Set(
projectsWithPreferredAgent.map(s => s.projectId)
);
const projectsToUpdate = projects.filter(p => !preferredAgentProjectIds.has(p.id));

const bulkMutateSelectedAgent = useBulkMutateSelectedAgent({
projects: projectsToUpdate,
});
const initialValue = preferredAgent.data ? preferredAgent.data : ('seer' as const);

Comment thread
sentry[bot] marked this conversation as resolved.
return (
<AutoSaveForm
name="agentId"
schema={z.object({agentId: z.string()})}
initialValue={preferredAgentValue}
mutationOptions={codingAgentMutationOpts}
name="integration"
schema={z.object({
integration: z.union([z.literal('seer'), z.custom<CodingAgentIntegration>()]),
})}
initialValue={initialValue}
Copy link
Copy Markdown
Contributor

@cursor cursor Bot Apr 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Form shows wrong initial value after async load

High Severity

When the org has a non-seer preferred agent (via defaultCodingAgentIntegrationId), useFetchPreferredAgent introduces an async loading phase where data is undefined. During loading, initialValue falls back to 'seer', and AutoSaveForm mounts with defaultValues: {integration: 'seer'}. TanStack Form's defaultValues does not update after mount, so once loading completes the form state stays stuck on 'seer' even though the actual agent is different. The old code computed the value synchronously from org props with no loading state, so this is a regression.

Additional Locations (1)
Fix in Cursor Fix in Web

mutationOptions={codingAgentMutationOptions}
>
{field => (
<Stack gap="md">
Expand All @@ -219,12 +181,24 @@ function AgentNameForm({
)}
>
<Container flexGrow={1}>
<field.Select
value={field.state.value}
onChange={field.handleChange}
disabled={!canWrite}
options={codingAgentOptions}
/>
{preferredAgent.isPending || codingAgentSelectOptions.isPending ? (
<Placeholder height="36px" width="100%" />
) : codingAgentSelectOptions.isError ? (
<Alert variant="danger">
{t('Failed to fetch coding agent options')}
</Alert>
) : (
<field.Select
value={field.state.value as CodingAgentIntegration | 'seer'}
onChange={field.handleChange}
disabled={!canWrite}
options={codingAgentSelectOptions.data}
isValueEqual={(a, b) =>
a === b ||
(typeof a === 'object' && typeof b === 'object' && a.id === b.id)
}
/>
)}
</Container>
</field.Layout.Row>

Expand All @@ -236,13 +210,14 @@ function AgentNameForm({
!canWrite ||
isBulkMutatingAgent ||
isBulkMutatingCreatePr ||
!preferredAgentIntegration ||
projectsWithPreferredAgent.length === projects.length
preferredAgent.isPending ||
codingAgentSelectOptions.isPending ||
projectsIdsWithPreferredAgent.size === projects.length
}
onClick={async () => {
if (preferredAgentIntegration) {
if (preferredAgent.data) {
setIsBulkMutatingAgent(true);
await bulkMutateSelectedAgent(preferredAgentIntegration, {});
await bulkMutateSelectedAgent(preferredAgent.data);
setIsBulkMutatingAgent(false);
} else {
addErrorMessage(t('No coding agent integration found'));
Expand All @@ -252,25 +227,27 @@ function AgentNameForm({
{tn(
'Set for the existing project',
'Set for all existing projects',
projectsWithPreferredAgent.length
projectsIdsWithPreferredAgent.size
)}
</Button>
<Text variant="secondary" size="sm">
{projects.length === 0
? t('No projects found')
: projects.length === 1
? projectsWithPreferredAgent.length === 1
? t('Your existing project uses %s', preferredAgentLabel)
: t('Your existing project does not use %s', preferredAgentLabel)
: projects.length === projectsWithPreferredAgent.length
? t('All existing projects use %s', preferredAgentLabel)
: t(
'%s of %s existing projects use %s',
projectsWithPreferredAgent.length,
projects.length,
preferredAgentLabel
)}
</Text>
{preferredAgentLabel ? (
<Text variant="secondary" size="sm">
{projects.length === 0
? t('No projects found')
: projects.length === 1
? projectsIdsWithPreferredAgent.size === 1
? t('Your existing project uses %s', preferredAgentLabel)
: t('Your existing project does not use %s', preferredAgentLabel)
: projects.length === projectsIdsWithPreferredAgent.size
? t('All existing projects use %s', preferredAgentLabel)
: t(
'%s of %s existing projects use %s',
projectsIdsWithPreferredAgent.size,
projects.length,
preferredAgentLabel
)}
</Text>
) : null}
</Flex>
</Stack>
)}
Expand Down
Loading
Loading