fix(stories): adjust search scroll behavior#112045
Merged
natemoo-re merged 5 commits intomasterfrom Apr 8, 2026
Merged
Conversation
Member
|
@natemoo-re I found the perf in dev mode to be quite poor if we don't virtualize the list, did that improve through some other change, or what allows us to drop the virtualization? |
Collaborator
|
Ideally we’d keep virtualization but drop the second scrollbar :) |
7427a00 to
d39356e
Compare
d39356e to
d3e2697
Compare
TkDodo
approved these changes
Apr 8, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
removes hardcoded position overrides in story search and removes virtualization fixes DE-1042, DE-1022 See [Preview Deployment](https://sentry-git-stories-search-scroll.sentry.dev/stories)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
removes hardcoded position overrides in story search and removes virtualization
fixes DE-1042, DE-1022
See Preview Deployment