ref(cells): clean up dead is_historical_monolith region handling#112053
Closed
ref(cells): clean up dead is_historical_monolith region handling#112053
Conversation
hybrid cloud migration happened years ago, we shouldn't keep temporary code for the migration around, which special cases the "us" region
github-actions
bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
| return invite_context | ||
| # The pre-silo migration invite URL format omitted the org ID/slug. | ||
| # Those links have long since expired, so we no longer attempt to resolve them. | ||
| return None |
Contributor
There was a problem hiding this comment.
Dead function stub with unused parameters remains
Low Severity
handle_empty_organization_id_or_slug now unconditionally returns None and none of its three parameters (member_id, user_id, request) are used. This is dead code that outlived the cleanup — the function and its call in get_invite_state could be replaced with a direct return None (with the comment inline), removing an unnecessary layer of indirection.
Additional Locations (1)
Contributor
Backend Test FailuresFailures on
|
lynnagara
added a commit
that referenced
this pull request
Apr 2, 2026
this removes the pre-silo organization invite path. this fundamentally does not work in the regional or cell world -- all org specific routes need to contain the org identifier (id or slug) in order to target the correct cell. since we have not sent invites using this path for many years, it should be safe to remove this is a prequisite to #112053 and other codebase cleanups
markstory
reviewed
Apr 7, 2026
Member
markstory
left a comment
markstory
left a comment
There was a problem hiding this comment.
Test failures look relevant
| @@ -32,41 +28,9 @@ | |||
| def handle_empty_organization_id_or_slug( | |||
Member
There was a problem hiding this comment.
Do we need to keep this function? It is not used in getsentry.
Member
Author
|
closing for now, need to wait until may 8th to remove this. after this date all the invite links previously sent to legacy urls would be expired and this can all removed along with a number of other related code paths |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hybrid cloud migration happened years ago, we shouldn't keep temporary code for the migration around, which special cases the "us" region