feat(preprod): Register feature flag and project option for snapshot PR comments#112100
Merged
runningcode merged 2 commits intomasterfrom Apr 2, 2026
Merged
feat(preprod): Register feature flag and project option for snapshot PR comments#112100runningcode merged 2 commits intomasterfrom
runningcode merged 2 commits intomasterfrom
Conversation
…PR comments Add the infrastructure needed to gate snapshot PR comments: - Feature flag: organizations:preprod-snapshot-pr-comments - Project option: sentry:preprod_snapshot_pr_comments_enabled (default true) - Serializer field and PUT handler in project details endpoint Refs EME-999 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Backend
Member
|
Not aware of the general approach here, so forgive me if this is obvious from context, but I wonder why we need both an org feature flag and and project option? Once GAd, will there be an option to turn this on/off on a per project basis |
Contributor
Author
|
Good question, yes exactly, once GA, we will allow an option to turn this on/off an a per project basis with a settings toggle. Is this the right approach for that? |
shellmayr
approved these changes
Apr 2, 2026
Member
There was a problem hiding this comment.
Looks good to me - it would still be a good idea in my opinion to add some tests to prevent future regressions on the project option, as well as to make sure the defaults are enforced correctly there.
Verify that the preprodSnapshotPrCommentsEnabled field persists to the sentry:preprod_snapshot_pr_comments_enabled project option. Refs EME-999 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Thank you! I added a small test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Register the infrastructure needed to gate snapshot PR comments:
organizations:preprod-snapshot-pr-comments(FlagPole, api_expose=True)sentry:preprod_snapshot_pr_comments_enabled(default true)This is the first step toward EME-999 — adding PR comment support for snapshot comparisons. Follow-up PRs will add the task, template, frontend toggle, and trigger wiring.
Refs EME-999