chore(tracemetrics): Cleanup side panel feature flag#112105
Merged
nsdeschenes merged 4 commits intomasterfrom Apr 9, 2026
Merged
chore(tracemetrics): Cleanup side panel feature flag#112105nsdeschenes merged 4 commits intomasterfrom
nsdeschenes merged 4 commits intomasterfrom
Conversation
… feature flag The side panel is now fully rolled out, so remove the flag check and render the MetricDetailPanel unconditionally. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
…e panel Remove the test asserting the side panel is hidden without the flag, and simplify the remaining side panel tests to use the base organization fixture now that the panel always renders. Co-Authored-By: Claude Sonnet 4 <noreply@example.com>
github-actions
bot
added
the
Scope: Frontend
…lidate test setup After removing the side panel feature flag, the attributes endpoint is always fetched. Tests that called MockApiClient.clearMockResponses() mid-test were losing the attributes mock set up in beforeEach, causing unmocked request errors. Move all mock setup to beforeEach and cleanup to afterEach. Expand the events mock in metricSelectRow.spec.tsx to include all metric types so individual tests no longer need to clear and re-declare their own mocks. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
…epanel-feature-flag
k-fish
approved these changes
Apr 8, 2026
nsdeschenes
deleted the
nd/LOGS-600/chore-tracemetrics-cleanup-sidepanel-feature-flag
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Now that this flag has been fully rolled out, lets do some tidying up by removing it, and defaulting to the side panel experience. Ticket: LOGS-600 --------- Co-authored-by: Claude Sonnet 4 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that this flag has been fully rolled out, lets do some tidying up by removing it, and defaulting to the side panel experience.
Ticket: LOGS-600