DNM - Forcing a snapshot diff

[rbro112]

Forcing a snapshot diff, just as an example

[rbro112]

• DNM - Forcing a snapshot diff #112109 👈 (View in Graphite)
• master

This stack of pull requests is managed by Graphite. Learn more about stacking.

[sentry]

Bug: The getButtonTheme function incorrectly returns success theme colors for the danger case, causing buttons for destructive actions to appear green instead of red.
_{Severity: HIGH}

Suggested Fix

In the case 'danger': block within the getButtonTheme function, change the theme token references from theme.tokens.interactive.chonky.embossed.success back to theme.tokens.interactive.chonky.embossed.danger for the surface, background, and color properties.

Prompt for AI Agent

Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/components/core/button/styles.tsx#L293-L295

Potential issue: In the `getButtonTheme` function, the `case 'danger':` block has been
modified to return theme tokens associated with 'success' instead of 'danger'. This will
cause all buttons with `priority="danger"`, which are used for destructive actions like
deleting projects or revoking keys, to be rendered with green "success" colors instead
of the expected red "danger" colors. This affects over 170 instances in the codebase,
creating a significant user experience and safety issue by visually misrepresenting the
consequence of critical actions.

_{Did we get this right? 👍 / 👎 to inform future reviews.}