ref(preprod): Call status check tasks synchronously

[NicoHinderling]

Replace apply_async calls with direct synchronous invocations for preprod
status check tasks in the approval endpoint and GitHub check run webhook handler.

This ensures status checks run inline rather than being dispatched to the Celery
task queue, giving immediate feedback on approval actions.

sentry URL for tracking the latency of our status check tasks

[github-actions]

Backend Test Failures

Failures on a17f297 in this run:

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_creates_approval_for_valid_request — log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:196: in test_creates_approval_for_valid_request
    mock_task.apply_async.assert_called_once_with(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:988: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'apply_async' to be called once. Called 0 times.

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

[github-actions]

Backend Test Failures

Failures on 3d8b020 in this run:

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_allows_different_user_to_create_new_approval — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:400: in test_allows_different_user_to_create_new_approval
    handle_preprod_check_run_event(
src/sentry/preprod/vcs/webhooks/github_check_run.py:231: in handle_preprod_check_run_event
    raise ValueError(f"Unknown identifier: {identifier}")
E   ValueError: Unknown identifier: approve_size

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_checks_latest_approval_not_first — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:451: in test_checks_latest_approval_not_first
    handle_preprod_check_run_event(
src/sentry/preprod/vcs/webhooks/github_check_run.py:231: in handle_preprod_check_run_event
    raise ValueError(f"Unknown identifier: {identifier}")
E   ValueError: Unknown identifier: approve_size

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_creates_approval_for_valid_request — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:178: in test_creates_approval_for_valid_request
    handle_preprod_check_run_event(
src/sentry/preprod/vcs/webhooks/github_check_run.py:231: in handle_preprod_check_run_event
    raise ValueError(f"Unknown identifier: {identifier}")
E   ValueError: Unknown identifier: approve_size

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_creates_approvals_for_all_sibling_artifacts — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:221: in test_creates_approvals_for_all_sibling_artifacts
    handle_preprod_check_run_event(
src/sentry/preprod/vcs/webhooks/github_check_run.py:231: in handle_preprod_check_run_event
    raise ValueError(f"Unknown identifier: {identifier}")
E   ValueError: Unknown identifier: approve_size

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_skips_duplicate_approval_from_same_user — log

[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:367: in test_skips_duplicate_approval_from_same_user
    handle_preprod_check_run_event(
src/sentry/preprod/vcs/webhooks/github_check_run.py:231: in handle_preprod_check_run_event
    raise ValueError(f"Unknown identifier: {identifier}")
E   ValueError: Unknown identifier: approve_size

[github-actions]

Backend Test Failures

Failures on aaa026f in this run:

tests/sentry/preprod/vcs/webhooks/test_github_check_run.py::HandlePreprodCheckRunEventTest::test_creates_approval_for_valid_request — log

[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/preprod/vcs/webhooks/test_github_check_run.py:196: in test_creates_approval_for_valid_request
    mock_task.apply_async.assert_called_once_with(
/opt/hostedtoolcache/Python/3.13.1/x64/lib/python3.13/unittest/mock.py:988: in assert_called_once_with
    raise AssertionError(msg)
E   AssertionError: Expected 'apply_async' to be called once. Called 0 times.