fix(lint): Close S016 loophole for attribute-access ThreadPoolExecutor#112170
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
gricha
force-pushed
the
s016-attribute-access-loophole
branch
from
50c8370 to
b469d8f
Compare
S016 only checked `from concurrent.futures import ThreadPoolExecutor`. Writing `import concurrent.futures` then `concurrent.futures.ThreadPoolExecutor()` bypassed it entirely. Add a check in visit_Attribute that matches the full attribute chain. Fix one existing violation in the build script. Co-Authored-By: Claude Sonnet 4 <noreply@anthropic.com>
gricha
force-pushed
the
s016-attribute-access-loophole
branch
from
b469d8f to
c1fd600
Compare
JoshFerge
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
S016 only caught
from concurrent.futures import ThreadPoolExecutor(theImportFromAST node). Writingimport concurrent.futuresthen usingconcurrent.futures.ThreadPoolExecutor(...)bypassed the rule entirely.This adds a check in
visit_Attributethat matches when the attribute chain is exactlyconcurrent.futures.ThreadPoolExecutor— catches both calls and bare references, without flagging otherconcurrent.futures.*usage likeas_completedorFuture.Also fixes the one existing violation in
src/sentry/build/_integration_docs.py.Stacks on #112156.