fix(webhooks): Split out the metric alert action to be in a task#112177
Merged
Christinarlong merged 8 commits intomasterfrom Apr 3, 2026
Merged
fix(webhooks): Split out the metric alert action to be in a task#112177Christinarlong merged 8 commits intomasterfrom
Christinarlong merged 8 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
| retry=Retry(times=3, delay=60 * 5), | ||
| silo_mode=SiloMode.CELL, | ||
| ) | ||
| @retry_decorator |
Member
There was a problem hiding this comment.
Do we need the retry decorator if the Retry in the task decorator is already defined?
Contributor
Author
There was a problem hiding this comment.
yeah we still need the decorator as the decorator will specify on what exceptions to retry, alert or neither on.
shashjar
reviewed
Apr 2, 2026
shashjar
approved these changes
Apr 2, 2026
GabeVillalobos
approved these changes
Apr 3, 2026
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This comment was marked as outdated.
This comment was marked as outdated.
Christinarlong
added
the
Trigger: Revert
Contributor
|
PR reverted: 8a0a9a0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the metric alert webhook does not cross a task boundary and that the rpc call it does instead spawns off another thread to do the work we're getting errors when trying to use the sigalarm timeout.
This PR basically copies over the logic the metric alert trigger did but in a task. Also moves the work to be done via region/cell silo since idt we really want control tasks if we can avoid it/this task doesn't really have a reason to be in control