fix(test): open overlays immediately when in test mode#112196
Merged
JoshuaKGoldberg merged 4 commits intomasterfrom Apr 7, 2026
Merged
fix(test): open overlays immediately when in test mode#112196JoshuaKGoldberg merged 4 commits intomasterfrom
JoshuaKGoldberg merged 4 commits intomasterfrom
Conversation
JoshuaKGoldberg
added
the
Frontend: Rerun Flaky Tests
github-actions
bot
added
the
Scope: Frontend
This was referenced Apr 3, 2026
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
changed the title
JoshuaKGoldberg
force-pushed
the
JoshuaKGoldberg/fix/test-instant-hover-overlays
branch
from
d4b9304 to
5c8257a
Compare
JoshuaKGoldberg
force-pushed
the
JoshuaKGoldberg/fix/test-instant-hover-overlays
branch
from
5c8257a to
6dc0b86
Compare
github-actions
bot
added
the
Scope: Backend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
JoshuaKGoldberg
force-pushed
the
JoshuaKGoldberg/fix/test-instant-hover-overlays
branch
from
c11772f to
91364a0
Compare
useHoverOverlay opens overlays immediately when NODE_ENV is test so Tooltip, Hovercard, and GroupPreviewHovercard specs do not race OPEN_DELAY or production delay props. Production behavior is unchanged; explicit delay={0} still avoids setTimeout in production.
Drop redundant delay props from Tooltip/Hovercard specs and remove Hovercard tests that assumed deferred open.
Stabilize EventGroupingInfoSection specs by clearing FoldSection localStorage between runs and expanding the section before assertions so persisted collapse state cannot hide the View button (addresses ENG-7208 / overlap with #111926).
Refs ENG-7208 ENG-7211 ENG-7212
Made-with: Cursor
JoshuaKGoldberg
force-pushed
the
JoshuaKGoldberg/fix/test-instant-hover-overlays
branch
from
91364a0 to
e3c9572
Compare
JoshuaKGoldberg
removed
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
natemoo-re
approved these changes
Apr 3, 2026
Member
natemoo-re
left a comment
natemoo-re
left a comment
There was a problem hiding this comment.
Great refactor, nice work!
scttcper
approved these changes
Apr 6, 2026
scttcper
added a commit
that referenced
this pull request
Apr 6, 2026
Skip all framer-motion animations in tests via `MotionGlobalConfig.skipAnimations = true` so components render immediately without waiting for animation frames or transitions. Also bumps framer-motion from 12.23.12 to 12.38.0. Drawer test benchmarks (before → after): - globalDrawer/index.spec.tsx: 4.76s → 1.15s (~4x faster) - 5 other drawer test suites: 8.57s → 3.24s (~2.6x faster) Ref: #112196
JoshuaKGoldberg
deleted the
JoshuaKGoldberg/fix/test-instant-hover-overlays
branch
This was referenced Apr 7, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
Removes the pattern of passing `delay={0}` / `displayTimeout={0}` in
specs: for _opening_ hover overlays immediately. That's now done
automatically in `useHoverOverlay` when `NODE_ENV === "test"`. This way
we don't need to manually create & pipe zero-value delay props around
various components.
Note that _closing_ timing is unchanged. That way any triggers to portal
content / async events still have a grace period in tests.
A few seemingly-unrelated tests had to be updated to account for
overlays now suddenly being available. I think this is good, actually,
because they previously were relying on timed opening not having
happened yet. See 92f3779.
Fixes ENG-7208. Fixes ENG-7211. Fixes ENG-7212.
Supersedes #111926, #111928, #111929, and #112004.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the pattern of passing
delay={0}/displayTimeout={0}in specs: for opening hover overlays immediately. That's now done automatically inuseHoverOverlaywhenNODE_ENV === "test". This way we don't need to manually create & pipe zero-value delay props around various components.Note that closing timing is unchanged. That way any triggers to portal content / async events still have a grace period in tests.
A few seemingly-unrelated tests had to be updated to account for overlays now suddenly being available. I think this is good, actually, because they previously were relying on timed opening not having happened yet. See 92f3779.
Fixes ENG-7208. Fixes ENG-7211. Fixes ENG-7212.
Supersedes #111926, #111928, #111929, and #112004.