Skip to content

fix(typing): Type post-process#112203

Merged
thetruecpaul merged 1 commit intomasterfrom
cpaul/040326/postprocesstyping
Apr 3, 2026
Merged

fix(typing): Type post-process#112203
thetruecpaul merged 1 commit intomasterfrom
cpaul/040326/postprocesstyping

Conversation

@thetruecpaul
Copy link
Copy Markdown
Contributor

Just a bunch of missing types. Added it to strictlist at the file-level (rather than the usual module level) because I think this file is important and tasks is too big to do all at once.

@thetruecpaul thetruecpaul requested a review from a team April 3, 2026 17:07
@thetruecpaul thetruecpaul requested review from a team as code owners April 3, 2026 17:07
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2026
from sentry.sentry_apps.services.app import app_service

if TYPE_CHECKING:
from django.utils.functional import _StrPromise
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:squint:

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taken from the file that's returning the _StrPromise. ¯_(ツ)_/¯

@thetruecpaul thetruecpaul enabled auto-merge (squash) April 3, 2026 17:16
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Backend Test Failures

Failures on 3f74b7c in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registeredlog
[gw1] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.integrations.github.tasks.sync_repos_on_install_change
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 3, 2026

Backend Test Failures

Failures on 4e8d386 in this run:

tests/sentry/taskworker/test_config.py::test_all_instrumented_tasks_registeredlog
[gw0] linux -- Python 3.13.1 /home/runner/work/sentry/sentry/.venv/bin/python3
tests/sentry/taskworker/test_config.py:120: in test_all_instrumented_tasks_registered
    raise AssertionError(
E   AssertionError: Found 1 module(s) with @instrumented_task that are NOT registered in TASKWORKER_IMPORTS.
E   These tasks will not be discovered by the taskworker in production!
E   
E   Missing modules:
E     - sentry.integrations.github.tasks.sync_repos_on_install_change
E   
E   Add these to TASKWORKER_IMPORTS in src/sentry/conf/server.py

Just a bunch of missing types. Added it to strictlist at the file-level (rather than the usual module level) because I think this file is important and tasks is too big to do all at once.
@thetruecpaul thetruecpaul force-pushed the cpaul/040326/postprocesstyping branch from 38dba69 to be0e4d0 Compare April 3, 2026 17:58
@thetruecpaul thetruecpaul merged commit 167e0ea into master Apr 3, 2026
109 checks passed
@thetruecpaul thetruecpaul deleted the cpaul/040326/postprocesstyping branch April 3, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants