Skip to content

feat(supergroups): Show filtered vs total events in supergroup chart#112215

Merged
scttcper merged 6 commits intomasterfrom
scttcper/feat-supergroup-filtered-chart
Apr 6, 2026
Merged

feat(supergroups): Show filtered vs total events in supergroup chart#112215
scttcper merged 6 commits intomasterfrom
scttcper/feat-supergroup-filtered-chart

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Apr 3, 2026

When search filters are active, individual issue rows show matching events vs total events as separate series in the chart. Supergroup rows were only showing total stats. This aggregates filtered stats separately so the supergroup row renders the same dual-bar chart with matching/total event and user counts.

Move stuff out of app/utils

image

When search filters are active, individual issue rows show matching
events vs total events as separate series in the chart. Supergroup
rows were only showing total stats. This aggregates filtered stats
separately so the supergroup row renders the same dual-bar chart
with matching/total event and user counts.
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 3, 2026
Remove unnecessary fallbacks and redundant truthiness guards:
- Drop || 0 on count/userCount since types guarantee valid values
- Use ??= for null-to-zero init on filtered accumulators
- Remove optional chaining on stats record lookups
- Remove truthiness check on firstSeen/lastSeen since ?? fallback
  always produces a string
scttcper added 2 commits April 3, 2026 14:15
These utilities are only used by the issue list. Colocate them with
the rest of the supergroup code instead of keeping them in utils/.
group.stats can be undefined at runtime when group data hasn't fully
loaded, even though the type says Record<string, ...>. The optional
chaining was incorrectly removed in the cleanup pass.
@scttcper scttcper marked this pull request as ready for review April 3, 2026 21:35
@scttcper scttcper requested review from a team as code owners April 3, 2026 21:35
@scttcper scttcper merged commit 1a2ec01 into master Apr 6, 2026
78 checks passed
@scttcper scttcper deleted the scttcper/feat-supergroup-filtered-chart branch April 6, 2026 17:32
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…112215)

When search filters are active, individual issue rows show matching
events vs total events as separate series in the chart. Supergroup rows
were only showing total stats. This aggregates filtered stats separately
so the supergroup row renders the same dual-bar chart with
matching/total event and user counts.

Move stuff out of app/utils

<img width="259" height="167" alt="image"
src="https://github.com/user-attachments/assets/8a9939e6-e91d-4c5c-a1ec-3ddcee3c2747"
/>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants