feat(supergroups): Show filtered vs total events in supergroup chart#112215
Merged
feat(supergroups): Show filtered vs total events in supergroup chart#112215
Conversation
When search filters are active, individual issue rows show matching events vs total events as separate series in the chart. Supergroup rows were only showing total stats. This aggregates filtered stats separately so the supergroup row renders the same dual-bar chart with matching/total event and user counts.
Remove unnecessary fallbacks and redundant truthiness guards: - Drop || 0 on count/userCount since types guarantee valid values - Use ??= for null-to-zero init on filtered accumulators - Remove optional chaining on stats record lookups - Remove truthiness check on firstSeen/lastSeen since ?? fallback always produces a string
These utilities are only used by the issue list. Colocate them with the rest of the supergroup code instead of keeping them in utils/.
group.stats can be undefined at runtime when group data hasn't fully loaded, even though the type says Record<string, ...>. The optional chaining was incorrectly removed in the cleanup pass.
cvxluo
approved these changes
Apr 6, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…112215) When search filters are active, individual issue rows show matching events vs total events as separate series in the chart. Supergroup rows were only showing total stats. This aggregates filtered stats separately so the supergroup row renders the same dual-bar chart with matching/total event and user counts. Move stuff out of app/utils <img width="259" height="167" alt="image" src="https://github.com/user-attachments/assets/8a9939e6-e91d-4c5c-a1ec-3ddcee3c2747" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When search filters are active, individual issue rows show matching events vs total events as separate series in the chart. Supergroup rows were only showing total stats. This aggregates filtered stats separately so the supergroup row renders the same dual-bar chart with matching/total event and user counts.
Move stuff out of app/utils