Skip to content

bug(snapshots): Fix bug in snapshots status check where approval not reflected in status column#112223

Merged
rbro112 merged 2 commits into
masterfrom
ryan/04-03-fix_bug_in_snapshots_status_check_where_approval_not_reflected_in_status_column
Apr 3, 2026
Merged

bug(snapshots): Fix bug in snapshots status check where approval not reflected in status column#112223
rbro112 merged 2 commits into
masterfrom
ryan/04-03-fix_bug_in_snapshots_status_check_where_approval_not_reflected_in_status_column

Conversation

@rbro112
Copy link
Copy Markdown
Member

@rbro112 rbro112 commented Apr 3, 2026

"Approved" wasn't being set in the "status" column of status checks as we simply never wired that up. This fixes it to properly post "approved" once snapshot diffs are approved.

Resolves EME-1004

@rbro112 rbro112 requested a review from a team as a code owner April 3, 2026 19:51
Copy link
Copy Markdown
Member Author

rbro112 commented Apr 3, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 3, 2026
@rbro112 rbro112 changed the title Fix bug in snapshots status check where approval not reflected in status column bug(snapshots): Fix bug in snapshots status check where approval not reflected in status column Apr 3, 2026
@linear-code
Copy link
Copy Markdown

linear-code Bot commented Apr 3, 2026

@rbro112 rbro112 merged commit dd54a06 into master Apr 3, 2026
65 checks passed
@rbro112 rbro112 deleted the ryan/04-03-fix_bug_in_snapshots_status_check_where_approval_not_reflected_in_status_column branch April 3, 2026 21:46
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants