ref(ci-st): fast calculate-shards heuristics#112319
Merged
Merged
Conversation
github-actions
Bot
added
the
Scope: Backend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 525fa4f. Configure here.
rbro112
approved these changes
Apr 7, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
no more setup-sentry and pytest --collect-only! test count is only used to calculate shards and we don't need 100% accuracy, even ~90% is acceptable. this completely eliminates 2m serial per-workflow! we now count test_ with a regex across SELECTED_FILES and ast-based parsing for `@pytest.mark.parametrize multipliers` (inline lists, variable references, subscript access, stacked decorators, stored decorators). this is ~99% accurate because there are only 7 `@pytest.fixture(params=...)` which cannot be statically determined, and we have ~30k tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
no more setup-sentry and pytest --collect-only! test count is only used to calculate shards and we don't need 100% accuracy, even ~90% is acceptable.
this completely eliminates 2m serial per-workflow!
we now count test_ with a regex across SELECTED_FILES and ast-based parsing for
@pytest.mark.parametrize multipliers(inline lists, variable references, subscript access, stacked decorators, stored decorators).this is ~99% accurate because there are only 7
@pytest.fixture(params=...)which cannot be statically determined, and we have ~30k tests