fix(ownership): Handle ownership rule owners without an id#112321
Merged
Conversation
The backend can return ownership rule owners with just a name and type but no id — this happens with unresolved codeowner entries. The frontend was treating `id` as always present which broke avatar rendering and the "my teams" filter. Make `id` optional on `OwnershipRuleOwner`, skip avatar stack rendering for owners missing an id, and filter them out of the owner selector. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
cvxluo
approved these changes
Apr 7, 2026
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
update our frontend types to match the new backend types added in #110604 Make `id` optional on `OwnershipRuleOwner`, skip the avatar stack for owners missing an id, and filter them out of the owner selector. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update our frontend types to match the new backend types added in #110604
Make
idoptional onOwnershipRuleOwner, skip the avatar stack for owners missing an id, and filter them out of the owner selector.