Skip to content

fix(codeowners): Add coverage for markdownTextArea and clean baseline#112339

Merged
chromy merged 3 commits intomasterfrom
chromy/fix-codeowners-coverage
Apr 7, 2026
Merged

fix(codeowners): Add coverage for markdownTextArea and clean baseline#112339
chromy merged 3 commits intomasterfrom
chromy/fix-codeowners-coverage

Conversation

@chromy
Copy link
Copy Markdown
Contributor

@chromy chromy commented Apr 7, 2026

Add markdownTextArea.tsx to CODEOWNERS

Agent transcript: https://claudescope.sentry.dev/share/871UYxUBaZ8vQJ9ftWv61JC9JCwVPM23lLo0kqC_Q3o

@chromy chromy requested a review from a team as a code owner April 7, 2026 09:31
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Wrong team assigned in CODEOWNERS for markdownTextArea
    • Moved markdownTextArea.tsx from @getsentry/app-frontend to @getsentry/alerts-create-issues in the Workflow Engine section to match the PR intent and actual usage.

Create PR

Or push these changes by commenting:

@cursor push d9f98a3ac3
Preview (d9f98a3ac3)
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -439,7 +439,6 @@
 /static/app/components/loading/                @getsentry/app-frontend
 /static/app/components/events/interfaces/      @getsentry/app-frontend
 /static/app/components/forms/                  @getsentry/app-frontend
-/static/app/components/markdownTextArea.tsx     @getsentry/app-frontend
 /static/app/locale.tsx                         @getsentry/app-frontend
 ## End of Frontend
 
@@ -449,6 +448,7 @@
 /static/app/components/workflowEngine/                     @getsentry/alerts-create-issues
 /static/app/views/automations/                             @getsentry/alerts-create-issues
 /static/app/views/detectors/                               @getsentry/alerts-create-issues
+/static/app/components/markdownTextArea.tsx                @getsentry/alerts-create-issues
 # End of Workflow Engine (ACI)
 
 ## Integrations

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2ee1a73. Configure here.

Comment thread .github/CODEOWNERS Outdated
/static/app/components/loading/ @getsentry/app-frontend
/static/app/components/events/interfaces/ @getsentry/app-frontend
/static/app/components/forms/ @getsentry/app-frontend
/static/app/components/markdownTextArea.tsx @getsentry/app-frontend
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong team assigned in CODEOWNERS for markdownTextArea

Medium Severity

The PR description explicitly states markdownTextArea.tsx should be added under @getsentry/alerts-create-issues, but the actual change assigns it to @getsentry/app-frontend in the ## Frontend section. The only consumer of MarkdownTextArea is in static/app/views/detectors/, which is owned by @getsentry/alerts-create-issues. This means the wrong team will be tagged for reviews of this file.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 2ee1a73. Configure here.

Comment on lines 253 to 258
src/sentry/status_checks/__init__.py
src/sentry/status_checks/base.py
src/sentry/status_checks/warnings.py
src/sentry/synapse/__init__.py
src/sentry/synapse/endpoints/__init__.py
src/sentry/synapse/endpoints/authentication.py
src/sentry/synapse/endpoints/org_cell_mappings.py
src/sentry/synapse/paginator.py
src/sentry/tagstore/__init__.py
src/sentry/tagstore/base.py
src/sentry/tagstore/exceptions.py
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Removing synapse files from the coverage baseline without assigning a team in CODEOWNERS will cause the ownership check to be incorrectly skipped for these files.
Severity: MEDIUM

Suggested Fix

Either revert the removal of the synapse file entries from the codeowners-coverage-baseline.txt file, or assign a team to the /src/sentry/synapse/ and /tests/sentry/synapse/ entries in the main CODEOWNERS file to establish proper ownership.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/codeowners-coverage-baseline.txt#L253-L258

Potential issue: Entries for files under `/src/sentry/synapse/` and
`/tests/sentry/synapse/` were removed from the `codeowners-coverage-baseline.txt` file.
However, the corresponding `CODEOWNERS` entries for these directories do not assign a
team. The baseline file is intended to list files lacking coverage. By removing these
entries without assigning an owner, the CI check for code ownership will incorrectly
pass for these files, allowing future changes to be merged without proper team review
and accountability.

Did we get this right? 👍 / 👎 to inform future reviews.

Copy link
Copy Markdown
Contributor

@runningcode runningcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

chromy added 3 commits April 7, 2026 12:38
Add markdownTextArea.tsx to CODEOWNERS under alerts-create-issues team.
Remove 25 stale baseline entries that now have coverage.

Co-Authored-By: Claude Opus 4.6 <noreply@example.com>

Agent transcript: https://claudescope.sentry.dev/share/IEmMGgPQzG-gqDhJXCDBIwF1FKQeP96l2kCHwVMM7zA
This is a general-purpose UI component, not ACI-specific.

Co-Authored-By: Claude Opus 4.6 <noreply@example.com>

Agent transcript: https://claudescope.sentry.dev/share/Grtftj6MT03aAFw30LHWd4xIOEJxTfeSYc9oY333Y4Y
@chromy chromy force-pushed the chromy/fix-codeowners-coverage branch from f621318 to 5c5d55a Compare April 7, 2026 11:38
@chromy chromy merged commit fc84cb2 into master Apr 7, 2026
53 checks passed
@chromy chromy deleted the chromy/fix-codeowners-coverage branch April 7, 2026 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants