Skip to content

fix(preprod): Add tab=size to size status check settings URL #112352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mtopo27 merged 1 commit into from
Apr 7, 2026
+10 −7
Merged

fix(preprod): Add tab=size to size status check settings URL #112352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sentry/preprod/vcs/status_checks/size/templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -331,11 +331,12 @@ def _get_settings_url(
) -> str:
"""Build the settings URL for the project's preprod settings page."""
base_url = f"/settings/projects/{project.slug}/mobile-builds/"
query = "tab=size"
if triggered_rules:
unique_rule_ids = list(dict.fromkeys(tr.rule.id for tr in triggered_rules))
expanded_params = "&".join(f"expanded={rule_id}" for rule_id in unique_rule_ids)
return project.organization.absolute_url(base_url, query=expanded_params)
return project.organization.absolute_url(base_url)
query += "&" + expanded_params
return project.organization.absolute_url(base_url, query=query)


def _format_failed_checks_details(
Expand Down
12 changes: 7 additions & 5 deletions tests/sentry/preprod/vcs/status_checks/size/test_templates.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -965,7 +965,9 @@ def test_mixed_platforms_render_separate_tables(self) -> None:

android_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{android_artifact.id}"
ios_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{ios_artifact.id}"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/"
settings_url = (
f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size"
)

expected = f"""\
### Android Builds
Expand Down Expand Up @@ -1314,7 +1316,7 @@ def test_single_triggered_rule_shows_details_section(self) -> None:
artifact_url = (
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}"
)
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1"

expected = f"""\
## ❌ 1 Failed Size Check
Expand Down Expand Up @@ -1463,7 +1465,7 @@ def test_multiple_triggered_rules_url_formatting(self) -> None:
artifact_url = (
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact.id}"
)
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-download-absolute&expanded=rule-install-diff&expanded=rule-download-percent"

expected = f"""\
## ❌ 3 Failed Size Checks
Expand Down Expand Up @@ -1576,7 +1578,7 @@ def test_multiple_apps_with_triggered_rules(self) -> None:
artifact2_url = (
f"http://testserver/organizations/{self.organization.slug}/preprod/size/{artifact2.id}"
)
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1&expanded=rule-2"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1&expanded=rule-2"

expected = f"""\
## ❌ 2 Failed Size Checks
Expand Down Expand Up @@ -1680,7 +1682,7 @@ def test_mixed_pass_fail_with_triggered_rules(self) -> None:

failed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{failed_artifact.id}"
passed_url = f"http://testserver/organizations/{self.organization.slug}/preprod/size/{passed_artifact.id}"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?expanded=rule-1"
settings_url = f"http://testserver/settings/projects/{self.project.slug}/mobile-builds/?tab=size&expanded=rule-1"

expected = f"""\
## ❌ 1 Failed Size Check
Expand Down
Loading