feat(preprod): Add snapshot PR comments toggle to project settings#112362
feat(preprod): Add snapshot PR comments toggle to project settings#112362runningcode merged 1 commit intomasterfrom
Conversation
…ME-999) Add a toggle on the Snapshots tab in project settings to enable/disable snapshot PR comments, matching the existing build distribution toggle. Gated behind the preprod-snapshot-pr-comments feature flag.
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 2b881ec. Configure here.
| </PanelBody> | ||
| </Panel> | ||
| ); | ||
| } |
There was a problem hiding this comment.
New toggle component duplicates existing PR comments toggle
Low Severity
SnapshotPrCommentsToggle is a near-exact copy of PrCommentsToggle — both are 64 lines with identical structure, logic, and component tree. The only differences are the READ_KEY/WRITE_KEY constants and five label strings. A single shared component accepting those as props would eliminate the duplication, reducing the risk of the two toggles drifting out of sync if the toggle logic ever needs a bug fix.
Reviewed by Cursor Bugbot for commit 2b881ec. Configure here.
There was a problem hiding this comment.
I'm ok either way - extracting most of this to be a shared base or just leaving separate
There was a problem hiding this comment.
I'm going to merge as is. We're still not in beta and if we combine the logic then it sets it in stone. If we want to change / add more toggles it makes it trickier.
2 participants
Add a toggle on the Snapshots tab in Mobile Builds project settings to
enable/disable snapshot PR comments per project. Mirrors the existing
build distribution PR comments toggle on the Distribution tab.
The backend project option (
sentry:preprod_snapshot_pr_comments_enabled)and serializer field (
preprodSnapshotPrCommentsEnabled) were alreadyregistered — this PR adds the frontend toggle and the
Projecttypefield. Gated behind
organizations:preprod-snapshot-pr-comments.Refs EME-999
Added this here in the UI:
