fix(logs): adjust back-to-top containers to window width resize#112374
Merged
JoshuaKGoldberg merged 2 commits intomasterfrom Apr 8, 2026
Merged
fix(logs): adjust back-to-top containers to window width resize#112374JoshuaKGoldberg merged 2 commits intomasterfrom
JoshuaKGoldberg merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
JoshuaKGoldberg
commented
Apr 7, 2026
nsdeschenes
reviewed
Apr 7, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
I see you're using getBoundingClientRect, is there any chance that clientWidth would work?
We do have a useDimensions hook already 👀
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit edb8184. Configure here.
JoshuaKGoldberg
commented
Apr 7, 2026
JoshuaKGoldberg
commented
Apr 7, 2026
nsdeschenes
approved these changes
Apr 8, 2026
JoshuaKGoldberg
added a commit
that referenced
this pull request
Apr 9, 2026
…112460) Following up on #112374, I noted two things that could be simplified with `useDimensions`: * ~Runtime: it takes in an options object, but there's only one property. This means every call creates a new JS object. This is a little papercut for performance (almost certainly not impactful on its own, but they add up).~ This is intentional and preferred; reverted. * Types: its type parameter is unnecessary, and only bypasses [`@typescript-eslint/no-unnecessary-type-parameters`](https://typescript-eslint.io/rules/no-unnecessary-type-parameters) because it forwards the type parameter to `RefObject` (https://typescript-eslint.io/rules/no-unnecessary-type-parameters/#limitations)
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
) I would have preferred to get rid of JavaScript `tableWidth` altogether and use a pure CSS approach. But: * These are siblings of a table, which makes it tricky without adding additional DOM elements and mucking around with the layout * [CSS anchor positioning](https://developer.mozilla.org/en-US/docs/Web/CSS/Guides/Anchor_positioning) _would_ help us but Firefox only landed it as stable in 147. We support the last 10 Firefox versions; 146 will expire in September 2026 or so. I'm separately asking around internally about how/whether we track _"once browser support gets there"_ things like this. Fixes LOGS-672
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…112460) Following up on #112374, I noted two things that could be simplified with `useDimensions`: * ~Runtime: it takes in an options object, but there's only one property. This means every call creates a new JS object. This is a little papercut for performance (almost certainly not impactful on its own, but they add up).~ This is intentional and preferred; reverted. * Types: its type parameter is unnecessary, and only bypasses [`@typescript-eslint/no-unnecessary-type-parameters`](https://typescript-eslint.io/rules/no-unnecessary-type-parameters) because it forwards the type parameter to `RefObject` (https://typescript-eslint.io/rules/no-unnecessary-type-parameters/#limitations)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I would have preferred to get rid of JavaScript
tableWidthaltogether and use a pure CSS approach. But:I'm separately asking around internally about how/whether we track "once browser support gets there" things like this.
Fixes LOGS-672