Skip to content

(fix) add pendo as a known outside click#112388

Merged
cobyeastwood183 merged 2 commits intomasterfrom
fix-breadcrumb-drawer-outside-click
Apr 7, 2026
Merged

(fix) add pendo as a known outside click#112388
cobyeastwood183 merged 2 commits intomasterfrom
fix-breadcrumb-drawer-outside-click

Conversation

@cobyeastwood183
Copy link
Copy Markdown
Contributor

Third-party packages (e.g. Pendo) aren't considered as outside clicks for the breadcrumb drawer, this adds its container as an additional condition to check.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 7, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix prepared a fix for the issue found in the latest run.

  • ✅ Fixed: Unnecessary instanceof HTMLElement guard may miss non-HTML elements
    • Removed the instanceof HTMLElement narrowing so closest('#pendo-guide-container') now runs for all Element targets, preventing unintended drawer closes on SVG and other non-HTML nodes.

Create PR

Or push these changes by commenting:

@cursor push ac96c48d23
Preview (ac96c48d23)
diff --git a/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx b/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
--- a/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
+++ b/static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx
@@ -107,10 +107,8 @@
             }
             // Third-party packages (e.g. Pendo) use a container with id "pendo-guide-container".
             // If the click is inside that container, treat it as an internal click.
-            if (element instanceof HTMLElement) {
-              if (element.closest('#pendo-guide-container')) {
-                return false;
-              }
+            if (element.closest('#pendo-guide-container')) {
+              return false;
             }
             return true;
           },

This Bugbot Autofix run was free. To enable autofix for future PRs, go to the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 664e70a. Configure here.

Comment thread static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx Outdated
@cvxluo cvxluo requested a review from a team April 7, 2026 18:14
Comment thread static/app/components/events/breadcrumbs/breadcrumbsDataSection.tsx Outdated
…n.tsx

Co-authored-by: Scott Cooper <scttcper@gmail.com>
@cobyeastwood183 cobyeastwood183 merged commit 1de477a into master Apr 7, 2026
67 checks passed
@cobyeastwood183 cobyeastwood183 deleted the fix-breadcrumb-drawer-outside-click branch April 7, 2026 18:59
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
<!-- Describe your PR here. -->
Third-party packages (e.g. Pendo) aren't considered as outside clicks
for the breadcrumb drawer, this adds its container as an additional
condition to check.
<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.

---------

Co-authored-by: Scott Cooper <scttcper@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants