Skip to content

fix(dashboards): Add http_error_count_percent to function blocklist#112470

Merged
edwardgou-sentry merged 1 commit intomasterfrom
edwardgou-sentry/fix/dashboard-function-blocklist
Apr 8, 2026
Merged

fix(dashboards): Add http_error_count_percent to function blocklist#112470
edwardgou-sentry merged 1 commit intomasterfrom
edwardgou-sentry/fix/dashboard-function-blocklist

Conversation

@edwardgou-sentry
Copy link
Copy Markdown
Contributor

Adds http_error_count_percent to the Seer dashboard generation function blocklist to prevent it from being hallucinated in generated widget queries.

Prevent Seer from hallucinating the http_error_count_percent function
in generated dashboard widgets.
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner April 8, 2026 15:18
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! I'm wondering, should we just have an ALLOWLIST instead of BLOCKLIST? Its already pretty well defined in the dashboards frontend

@edwardgou-sentry edwardgou-sentry merged commit 92c4a09 into master Apr 8, 2026
57 checks passed
@edwardgou-sentry edwardgou-sentry deleted the edwardgou-sentry/fix/dashboard-function-blocklist branch April 8, 2026 20:04
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…112470)

Adds `http_error_count_percent` to the Seer dashboard generation
function blocklist to prevent it from being hallucinated in generated
widget queries.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants