feat(tracemetrics): Add skeleton for equation builder in Explore#112504
Merged
narsaynorath merged 13 commits intomasterfrom Apr 9, 2026
Merged
feat(tracemetrics): Add skeleton for equation builder in Explore#112504narsaynorath merged 13 commits intomasterfrom
narsaynorath merged 13 commits intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
k-fish
approved these changes
Apr 9, 2026
Member
k-fish
left a comment
k-fish
left a comment
There was a problem hiding this comment.
I don't see anything major, lgtm mostly looking at the feature flag boundary. Maybe get Nick to take a look too since he's touched this UI code more recently, he might spot anything amiss.
static/app/views/explore/metrics/hooks/useHasMetricEquations.tsx
Outdated
Show resolved
Hide resolved
static/app/views/explore/metrics/metricToolbar/aggregateDropdown.tsx
Outdated
Show resolved
Hide resolved
nsdeschenes
approved these changes
Apr 9, 2026
Contributor
nsdeschenes
left a comment
nsdeschenes
left a comment
There was a problem hiding this comment.
UI things all look good to me 👍
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 920ecbd. Configure here.
narsaynorath
deleted the
nar/feat/tracemetrics-add-equation-ui-to-explore
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
…2504) Adds the basic skeleton code to just get a new field rendering in the right spot. i.e. - Adds a new "Add Equation" button that's feature flagged - Relaxes a bunch of types to allow for `VisualizeEquation` as an option - "Add Metric" adds a chart _between_ the equations and metrics. If there's no equations, it just appends to the end - "Add Equation" always appends an empty equation at the end - Metrics appear as references in the equation builder UI -⚠️ the references are currently __not__ stable. i.e. I have not handled deletion properly so the equation will not update to maintain the references if labels have to "shift left" to accommodate for deleting. This will be a follow up PR since I think it's a separate concern than this PR is addressing - Equations show their raw expression text as a label - Users can delete the equation The code currently **does not** make a request to the backend properly. Expanding the equation references will happen in a following PR. The feature flag needed to see this is: `tracemetrics-equations-in-explore`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the basic skeleton code to just get a new field rendering in the right spot. i.e.
VisualizeEquationas an optionThe code currently does not make a request to the backend properly. Expanding the equation references will happen in a following PR.
The feature flag needed to see this is:
tracemetrics-equations-in-exploreScreen.Recording.2026-04-08.at.3.13.05.PM.mov