Skip to content

fix(detectors): Make AlertRuleDetector.objects filter out pending deletion Detectors by default#112550

Merged
kcons merged 2 commits intomasterfrom
kcons/nowmet
Apr 9, 2026
Merged

fix(detectors): Make AlertRuleDetector.objects filter out pending deletion Detectors by default#112550
kcons merged 2 commits intomasterfrom
kcons/nowmet

Conversation

@kcons
Copy link
Copy Markdown
Member

@kcons kcons commented Apr 8, 2026

If a Detector is being deleted, the AlertRuleDetector row should typically be filtered out.

@kcons kcons requested review from a team as code owners April 8, 2026 22:43
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 8, 2026
Copy link
Copy Markdown
Contributor

@saponifi3d saponifi3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit a53c7ea. Configure here.

Comment thread src/sentry/workflow_engine/models/alertrule_detector.py
@kcons kcons merged commit d5ca711 into master Apr 9, 2026
57 checks passed
@kcons kcons deleted the kcons/nowmet branch April 9, 2026 17:01
george-sentry pushed a commit that referenced this pull request Apr 9, 2026
…etion Detectors by default (#112550)

If a Detector is being deleted, the AlertRuleDetector row should
typically be filtered out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants