ref(performance): Remove browserHistory usages from some performance views#112554
ref(performance): Remove browserHistory usages from some performance views#112554
browserHistory usages from some performance views#112554Conversation
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5de2dd9. Configure here.
| }, | ||
| }) | ||
| }), | ||
| {replace: true} |
There was a problem hiding this comment.
Missing preventScrollReset in replace navigation causes scroll regression
Medium Severity
The redirectToPerformanceHomepage function passes {replace: true} to navigate but omits preventScrollReset: true. The old browserHistory.replace shim explicitly included preventScrollReset: true with a comment noting that useNavigate replace does not automatically prevent scroll reset, and that this was needed to replicate react-router 3 behavior. This causes a behavioral regression where the scroll position resets to the top when redirecting to the performance homepage.
Reviewed by Cursor Bugbot for commit 5de2dd9. Configure here.
There was a problem hiding this comment.
i feel like we'd want to reset scroll on redirect?
There was a problem hiding this comment.
^ i think it's fine to reset scroll if we're going to a completely different page
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
Makes sense! Is that comment by Cursor accurate?
| }, | ||
| }) | ||
| }), | ||
| {replace: true} |
3 participants
https://github.com/getsentry/frontend-tsc/issues/78
Removes
browserHistoryusages from some performance views.