Check project access during groupId issue linking#112605
Merged
geoffg-sentry merged 1 commit intomasterfrom Apr 9, 2026
Merged
Check project access during groupId issue linking#112605geoffg-sentry merged 1 commit intomasterfrom
geoffg-sentry merged 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
michelletran-sentry
approved these changes
Apr 9, 2026
geoffg-sentry
deleted the
geoffg-sentry/idor-external-issue-actions-project-access
branch
george-sentry
pushed a commit
that referenced
this pull request
Apr 9, 2026
IDOR allowed linking to other projects in the same org as we lacked a auth check during external issue link creation. Initially spotted in the POST to /external-issue-actions/ There's some other areas to check after this too around this `create_external_issue, delete_external_issue, get_select_options`, but saving for the next PR
geoffg-sentry
added a commit
that referenced
this pull request
Apr 15, 2026
) After #112605 I went hunting for some other vulnerabilities around external issue linking with some specific criteria for VULN-1434: - Enforce project-level access and respect open team membership - Maintain the control/cell boundaries, no redrawing of the silos and keep changes in RPC Found and fixed some in external issue creation and deletion while passing issueIDs in the same org: - Refactored _extract_lazy_object since it was private to installation_external_issue_actions - create_external_issue POST now auth checks with has_project_access, killing an IDOR - delete_external_issue DELETE does the same, killing another IDOR - get_select_options called with a projectId could hit other projects you weren't scoped for, hardened Updated schema in getsentry/sentry-api-schema#66 Now split properly to make User optional in the first merge, followed up by making it a requirement in the next PR. Will be enforced afterward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IDOR allowed linking to other projects in the same org as we lacked a auth check during external issue link creation. Initially spotted in the POST to /external-issue-actions/
There's some other areas to check after this too around this
create_external_issue, delete_external_issue, get_select_options, but saving for the next PR