Skip to content

feat(supergroups): Use issues search to highlight supergroup drawer issues#112640

Merged
scttcper merged 8 commits intomasterfrom
scttcper/supergroup-drawer-search
Apr 13, 2026
Merged

feat(supergroups): Use issues search to highlight supergroup drawer issues#112640
scttcper merged 8 commits intomasterfrom
scttcper/supergroup-drawer-search

Conversation

@scttcper
Copy link
Copy Markdown
Member

@scttcper scttcper commented Apr 9, 2026

Instead of highlighting the group ids that we know exist in the current page of search results, make a search query and display all the results that match + query all the groups in the supergroup.

Adjusts some of the styles and loading states for the items in the drawer

image

…drawer issues

Replace the `group=id` param approach with `issue.id:[ids]` search
queries. The drawer now makes two requests: one to load all supergroup
issues, and a second with the current stream query + filters to
determine which ones match. Matched issues sort to the top and get
highlighted. When opened from issue details (no stream context), only
the load request fires.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 9, 2026
@scttcper scttcper changed the title ref(supergroups): Use issues search to load and highlight supergroup drawer issues feat(supergroups): Use issues search to highlight supergroup drawer issues Apr 9, 2026
scttcper and others added 2 commits April 10, 2026 10:08
use a `filterWithCurrentSearch` boolean instead of threading query as a
prop, read location.query directly in the drawer. use group= for the
base fetch since issue.id:[] was slow. dim unmatched rows at 60%
opacity instead of the subtle border highlight + legend nobody noticed.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
scttcper and others added 2 commits April 10, 2026 13:04
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
show a small filter icon on rows that match the current search filters,
with a legend above the list. bring back the graph stats column. leave
gutter space for a future checkbox.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@scttcper scttcper marked this pull request as ready for review April 10, 2026 21:56
@scttcper scttcper requested review from a team as code owners April 10, 2026 21:56
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 2 potential issues.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7112d20. Configure here.

The IssueRow `> *` selector was applying padding-left to the
absolutely-positioned MatchedIcon too, shifting the filter icon.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@cvxluo cvxluo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small styling issue otherwise 👍

position: absolute;
top: 23px;
/* Positioned after where the checkbox will go */
left: -2px;
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

i think this looks a little off in the drawer

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think i fix this in #112752

Stacked on #112764

Removes the checkbox from the supergroup row in the main issue list and
simplifies the count to a static "X issues". Moves selection and bulk
actions into the drawer instead.

The drawer issue list now has per-row checkboxes and a header bar with
the full ActionSet (resolve, archive, merge, set priority, etc). The
header swaps between column labels and action buttons when issues are
selected - same pattern as the main issue list. Filter match indicator
sits above the checkbox, unread dot is hidden since it's not useful in
this context.

Also deletes `supergroupCheckbox.tsx`

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
@scttcper scttcper enabled auto-merge (squash) April 13, 2026 19:54
@scttcper scttcper merged commit 66f0361 into master Apr 13, 2026
60 checks passed
@scttcper scttcper deleted the scttcper/supergroup-drawer-search branch April 13, 2026 20:01
start,
end,
query: `${query} ${issueIdFilter}`,
limit: groupIds.length,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The query for matched groups uses the total group count as the limit, but the API silently truncates results to 100, causing incomplete highlighting for large supergroups.
Severity: MEDIUM

Suggested Fix

The frontend query for matchedGroups should handle pagination. Instead of a single request with a potentially large limit, it should make multiple paginated requests to fetch all matching group IDs, respecting the API's maximum limit of 100, until all results are retrieved and can be processed.

Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: static/app/views/issueList/supergroups/supergroupDrawer.tsx#L208

Potential issue: In `supergroupDrawer.tsx`, the query to find which issues in a
supergroup match the current filters uses `limit: groupIds.length`. However, the backend
API silently enforces a maximum limit of 100 results per request. When a supergroup
contains more than 100 issues, the API response will be truncated without any indication
to the frontend. As a result, issues that match the filter but are beyond the 100th
position will not be highlighted in the UI, leading to incomplete and incorrect results
for the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants