fix(seer): Add links to manage your agent integrations, #112642
fix(seer): Add links to manage your agent integrations, #112642
Conversation
github-actions
bot
added
the
Scope: Frontend
…er can choose an agent
ryan953
force-pushed
the
ryan953/fix-seer-settings-manage-agents-link
branch
from
dd3c630 to
b1a66aa
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b1a66aa. Configure here.
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
| to={{ | ||
| pathname: `/settings/${organization.slug}/integrations/`, | ||
| query: {category: 'coding agent'}, | ||
| }} | ||
| > | ||
| {t('Manage Coding Agent Integrations')} | ||
| </Link> | ||
| ), | ||
| } | ||
| )} | ||
| /> |
There was a problem hiding this comment.
Bug: The manageLink component is defined but will not be rendered because the translation string is missing the [manageLink:...] placeholder.
Severity: MEDIUM
Suggested Fix
Update the translation string in static/gsApp/views/seerAutomation/projects.tsx to include the [manageLink:...] placeholder where the link is intended to appear. This will ensure the manageLink component is rendered correctly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/gsApp/views/seerAutomation/projects.tsx#L27-L43
Potential issue: In `static/gsApp/views/seerAutomation/projects.tsx`, a `manageLink`
component is defined and passed to the `tct` function. However, the corresponding
translation string is missing the `[manageLink:...]` placeholder. The `tct` function's
implementation silently ignores components that are not referenced in the template
string. As a result, the "Manage Coding Agent Integrations" link, which was
intentionally added in this pull request, will be completely missing from the rendered
UI on the Autofix project list page, preventing users from accessing the integration
management page from this location.
Did we get this right? 👍 / 👎 to inform future reviews.
There was a problem hiding this comment.
wanna migrate this form to the scraps form 🥺 ?
There was a problem hiding this comment.
it can happen as a followup
| title: ({organization}: {organization: Organization}) => ( | ||
| <Flex gap="sm" align="center"> | ||
| {t('Preferred Coding Agent')} | ||
| <InfoTip |
There was a problem hiding this comment.
🥔 for using InfoTip here ❤️
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
You're not using the link in static/gsApp/views/seerAutomation/projects.tsx, but otherwise lgtm
| to={{ | ||
| pathname: `/settings/${organization.slug}/integrations/`, | ||
| query: {category: 'coding agent'}, | ||
| }} | ||
| > | ||
| {t('Manage Coding Agent Integrations')} | ||
| </Link> | ||
| ), | ||
| } | ||
| )} | ||
| /> |
3 participants
We should have these links to manage agents whenever a user can choose an agent.