Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions static/app/chartcuterie/explore.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -2,18 +2,31 @@ import type {Theme} from '@emotion/react';
import type {BarSeriesOption, LineSeriesOption} from 'echarts';

import {XAxis} from 'sentry/components/charts/components/xAxis';
import {YAxis} from 'sentry/components/charts/components/yAxis';
import {AreaSeries} from 'sentry/components/charts/series/areaSeries';
import {BarSeries} from 'sentry/components/charts/series/barSeries';
import {LineSeries} from 'sentry/components/charts/series/lineSeries';
import {timeSeriesItemToEChartsDataPoint} from 'sentry/utils/timeSeries/timeSeriesItemToEChartsDataPoint';
import {DisplayType} from 'sentry/views/dashboards/types';
import type {TimeSeries} from 'sentry/views/dashboards/widgets/common/types';
import {formatTimeSeriesLabel} from 'sentry/views/dashboards/widgets/timeSeriesWidget/formatters/formatTimeSeriesLabel';
import {formatYAxisValue} from 'sentry/views/dashboards/widgets/timeSeriesWidget/formatters/formatYAxisValue';

import {DEFAULT_FONT_FAMILY, makeSlackChartDefaults, slackChartSize} from './slack';
import type {RenderDescriptor} from './types';
import {ChartType} from './types';

/**
* Builds a y-axis axisLabel formatter from the first timeseries metadata.
*/
function makeYAxisFormatter(timeSeries: TimeSeries[]) {
const firstSeries = timeSeries[0];
const valueType = firstSeries?.meta?.valueType ?? 'number';
const valueUnit = firstSeries?.meta?.valueUnit;

return (value: number) => formatYAxisValue(value, valueType, valueUnit ?? undefined);
Comment thread
DominikB2014 marked this conversation as resolved.
}

type ExploreChartData = {
timeSeries: TimeSeries[];
type?: DisplayType;
Expand Down Expand Up @@ -67,6 +80,16 @@ export const makeExploreCharts = (theme: Theme): Array<RenderDescriptor<ChartTyp
};
}

const exploreYAxis = YAxis({
theme,
splitNumber: 3,
axisLabel: {
fontSize: 11,
fontFamily: DEFAULT_FONT_FAMILY,
formatter: makeYAxisFormatter(timeSeries),
},
});

const hasGroups = timeSeries.some(ts => ts.groupBy && ts.groupBy.length > 0);

if (!hasGroups) {
Expand All @@ -81,6 +104,7 @@ export const makeExploreCharts = (theme: Theme): Array<RenderDescriptor<ChartTyp

return {
...slackChartDefaults,
yAxis: exploreYAxis,
xAxis: exploreXAxis,
useUTC: true,
color,
Expand Down Expand Up @@ -110,6 +134,7 @@ export const makeExploreCharts = (theme: Theme): Array<RenderDescriptor<ChartTyp

return {
...slackChartDefaults,
yAxis: exploreYAxis,
xAxis: exploreXAxis,
useUTC: true,
color,
Expand Down
Loading