Skip to content

ref(snapshots): Track diff algorithm version on comparison results #112729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NicoHinderling merged 1 commit into from
Apr 10, 2026
+3 −1
Merged

ref(snapshots): Track diff algorithm version on comparison results #112729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/sentry/preprod/snapshots/image_diff/compare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
# This is NOT a minimum % changed value, but
# rather adjusts the sensitivity of pixel change detection.
ODIFF_SENSITIVITY_DIFF_THRESHOLD = 0.01
DIFF_ALGORITHM_VERSION = 1


def _as_image(source: bytes | Image.Image) -> Image.Image:
Expand Down
3 changes: 2 additions & 1 deletion src/sentry/preprod/snapshots/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@

from sentry.objectstore import get_preprod_session
from sentry.preprod.models import PreprodArtifact, PreprodComparisonApproval
from sentry.preprod.snapshots.image_diff.compare import compare_images_batch
from sentry.preprod.snapshots.image_diff.compare import DIFF_ALGORITHM_VERSION, compare_images_batch
from sentry.preprod.snapshots.image_diff.odiff import OdiffServer
from sentry.preprod.snapshots.manifest import (
ComparisonManifest,
Expand Down Expand Up @@ -668,6 +668,7 @@ def _fetch_hash(h: str) -> None:
extras = comparison.extras or {}
# EME-896: Could become a proper column on PreprodSnapshotComparison
extras["comparison_key"] = comparison_key
extras["diff_algorithm_version"] = DIFF_ALGORITHM_VERSION
comparison.extras = extras
comparison.save(
update_fields=[
Expand Down
Loading