fix(organizations): Fix negative lookahead in absolute_url for org slug 'new'#112800
Draft
fix(organizations): Fix negative lookahead in absolute_url for org slug 'new'#112800
Conversation
… trailing slash The pattern (?!new) incorrectly excluded org slugs that merely start with "new" (e.g. "newco", "newly") from /organizations/<slug>/ stripping, since the lookahead matched on the prefix alone. Changed to (?!new/) so only the literal path segment "new" (followed by a slash) triggers the exclusion.
github-actions
bot
added
the
Scope: Backend
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
absolute_url.pystrips/organizations/<slug>/from URL paths using:r"\/?organizations\/(?!new)[^/]+\/(.*)"The lookahead
(?!new)matches any slug that doesn't start with the string "new". This incorrectly excludes slugs like"newco"or"newly"— valid org slugs that happen to begin with "new".Fix
Adding the trailing slash to the lookahead means only the exact path segment
new/(i.e. an org literally named"new") triggers the exclusion. Slugs starting with "new" followed by any other character are now handled correctly.Test plan
Added a test case in
tests/sentry/organizations/test_absolute_url.pycovering slugs that start with "new" but are not exactly "new".