feat(np): Adds renderer for MSTeams issue alerts#112890
Draft
GabeVillalobos wants to merge 1 commit intomasterfrom
Draft
feat(np): Adds renderer for MSTeams issue alerts#112890GabeVillalobos wants to merge 1 commit intomasterfrom
GabeVillalobos wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
saponifi3d
reviewed
Apr 14, 2026
| return None | ||
|
|
||
| @classmethod | ||
| def build_actions(cls, *, group: Group, issue_url: str) -> list[Action]: |
Contributor
There was a problem hiding this comment.
should we remove the group here since it's not being used anymore?
|
|
||
| @classmethod | ||
| def build_actions(cls, *, group: Group, issue_url: str) -> list[Action]: | ||
| return [OpenUrlAction(type=ActionType.OPEN_URL, title="View Issue", url=issue_url)] |
Contributor
There was a problem hiding this comment.
It might be nice to take the title as a param here; so it's a little easier to modify in the future.
| ] | ||
|
|
||
| @classmethod | ||
| def get_renderer( |
Contributor
There was a problem hiding this comment.
🤔 any thoughts on this being a top level registry? i'm thinking something like: renderer = notification_renderer_registry(Provider.MS_TEAMS, Category.ISSUE)
Member
Author
There was a problem hiding this comment.
Not opposed to it at all. I'll sync with the team on why we went with this approach to begin with vs rolling another registry.
| class IssueMSTeamsRenderer(NotificationRenderer[MSTeamsRenderable]): | ||
| provider_key = NotificationProviderKey.MSTEAMS | ||
|
|
||
| @classmethod |
Contributor
There was a problem hiding this comment.
curious about the class methods on these vs having them be instance methods? is the design pattern here meant to be more generic and allow us to return classes from helper methods and invoke easily? (that's what the get_renderer method seems like at least)
Member
Author
There was a problem hiding this comment.
I'm not sure what the historical reason for it is, though I do like that it keeps the render classes fully stateless by design.
GabeVillalobos
force-pushed
the
gv/add_msteams_issue_renderer
branch
from
9380f1c to
38b1e86
Compare
Contributor
Backend Test FailuresFailures on
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.