Skip to content

ref(chartcuterie): Rename SLACK_EXPLORE_LINE to SLACK_TIMESERIES (backend)#112933

Merged
DominikB2014 merged 1 commit into
masterfrom
dominikbuszowiecki/rename-explore-line-to-timeseries-backend
Apr 14, 2026
Merged

ref(chartcuterie): Rename SLACK_EXPLORE_LINE to SLACK_TIMESERIES (backend)#112933
DominikB2014 merged 1 commit into
masterfrom
dominikbuszowiecki/rename-explore-line-to-timeseries-backend

Conversation

@DominikB2014
Copy link
Copy Markdown
Contributor

@DominikB2014 DominikB2014 commented Apr 14, 2026

Summary

  • Renames the ChartType.SLACK_EXPLORE_LINE enum member to ChartType.SLACK_TIMESERIES and its string value from slack:explore.line to slack:timeseries in the backend Python code
  • Updates the Slack explore unfurl handler and tests to use the new name

Work for https://linear.app/getsentry/issue/DAIN-1521/update-unfurl-handler-name

Test plan

  • Pre-commit passes
  • Existing test_unfurl tests pass with updated enum references

Rename the chart type enum from `SLACK_EXPLORE_LINE` / `slack:explore.line`
to `SLACK_TIMESERIES` / `slack:timeseries` as it more accurately describes
the chart type.
@DominikB2014 DominikB2014 requested review from a team as code owners April 14, 2026 16:31
@DominikB2014 DominikB2014 requested a review from a team April 14, 2026 16:31
@github-actions github-actions Bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 14, 2026
Copy link
Copy Markdown
Contributor

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ee0f5e8. Configure here.

Comment thread src/sentry/charts/types.py
Comment thread src/sentry/charts/types.py
@DominikB2014 DominikB2014 merged commit 88558f6 into master Apr 14, 2026
57 checks passed
@DominikB2014 DominikB2014 deleted the dominikbuszowiecki/rename-explore-line-to-timeseries-backend branch April 14, 2026 17:20
DominikB2014 added a commit that referenced this pull request Apr 14, 2026
…ntend) (#112934)

## Summary
- Renames the `ChartType.SLACK_EXPLORE_LINE` enum member to
`ChartType.SLACK_TIMESERIES` and its string value from
`slack:explore.line` to `slack:timeseries` in the frontend TypeScript
code
- Renames `explore.tsx` to `timeseries.tsx` and `makeExploreCharts` to
`makeTimeseriesCharts`
- Updates `config.tsx` import accordingly

This is because the handler covers all timeseries chart types, and it's
not specific to explore line charts

Depends on #112933

## Test plan
- [x] Pre-commit passes
- [ ] Chartcuterie config still registers the timeseries chart type
correctly
@github-actions github-actions Bot locked and limited conversation to collaborators May 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants