feat(tracemetrics): Add alert via dropdown in explore#112963
Merged
Conversation
Allows alerts to be added from the 'saveas' dropdown in metrics tab. Will show as 'monitors' for the new workflow engine ui.
github-actions
bot
added
the
Scope: Frontend
k-fish
commented
Apr 14, 2026
| const alertsUrls = metricQueries | ||
| .filter(mq => isVisualizeFunction(mq.queryParams.visualizes[0]!)) | ||
| .map((metricQuery, index) => { | ||
| const visualize = metricQuery.queryParams.visualizes[0]!; |
Member
Author
There was a problem hiding this comment.
We should prob fix this in another PR to not allow multiple if they are really 1:1
Contributor
Sentry Snapshot Testing
|
narsaynorath
approved these changes
Apr 14, 2026
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
Comment on lines
+52
to
+55
| const project = | ||
| projects.length === 1 | ||
| ? projects[0] | ||
| : projects.find(p => p.id === `${pageFilters.selection.projects[0]}`); |
Contributor
There was a problem hiding this comment.
Bug: When "All Projects" is selected, the project variable becomes undefined, causing the alert creation URL to lack a pre-selected project, degrading the user experience.
Severity: LOW
Suggested Fix
Add an explicit check to handle the "All Projects" case. If pageFilters.selection.projects is empty or contains the sentinel value for all projects, do not attempt to find a specific project. Instead, allow the alert creation URL to be generated without a project, or implement logic to handle this case as intended, ensuring the user experience is not degraded.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: static/app/views/explore/metrics/useSaveAsMetricItems.tsx#L52-L55
Potential issue: When a user has "All Projects" or "My Projects" selected in the metrics
explore view, the logic to determine the current project results in an `undefined`
value. This is because `projects.find(p => p.id ===
`${pageFilters.selection.projects[0]}`)` fails when `pageFilters.selection.projects[0]`
is `undefined` or `-1`. While the downstream `getAlertsUrl()` function handles the
`undefined` project gracefully by generating a URL without a project slug, this leads to
a functional regression. The user is navigated to the alert creation page but must
manually re-select the project, losing the context from the explore view.
Did we get this right? 👍 / 👎 to inform future reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows alerts to be added from the 'saveas' dropdown in metrics tab. Will show as 'monitors' for the new workflow engine ui.
Equations are not allowed since they aren't supported in alerts yet.