ref(scm): Implement sentry-scm dependency#112969
Merged
Conversation
github-actions
bot
added
the
Scope: Backend
github-actions
bot
added
the
Scope: Frontend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Contributor
Sentry Snapshot Testing
|
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
Contributor
Backend Test FailuresFailures on
|
…/getsentry/sentry into cmanallen/implement-scm-platform
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
Contributor
Backend Test FailuresFailures on
|
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
billyvg
approved these changes
Apr 15, 2026
| publish_status = { | ||
| "POST": ApiPublishStatus.EXPERIMENTAL, | ||
| } | ||
| publish_status = {"GET": ApiPublishStatus.EXPERIMENTAL, "POST": ApiPublishStatus.EXPERIMENTAL} |
Member
There was a problem hiding this comment.
tbh dont remember what this does, (is it for openapi?) but shouldn't it be private?
| ), | ||
| re_path( | ||
| r"^scm-rpc/(?P<method_name>\w+)/$", | ||
| r"^scm-rpc/$", |
Member
There was a problem hiding this comment.
where does the method routing get handled now?
Member
Author
There was a problem hiding this comment.
The equivalent of method is handled in the POST body.
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0e43521. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces
sentry/scmimplementation with a newsentry-scmdependency.sentry-scmreplicates the behavior ofsentry/scmbut moves it to a third-party package so that it may be distributed to multiple services.There is a minor refactor contained in here. It was a simplification of some overly complex behaviors and a reduction in the SourceCodeManager class's instantiation capabilities. Previously we allowed initialization from an integration instance. However, this goes against one of the goals of the SCM which is to enforce access-controls. For now its been removed. This optimization can be added later if necessary.