Conversation
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.
|
|
||
| &[data-stuck] { | ||
| box-shadow: ${p => p.theme.dropShadowHeavyTop}; | ||
| box-shadow: ${p => p.theme.shadow.high}; |
There was a problem hiding this comment.
Footer shadow direction changed from upward to downward
Medium Severity
The old dropShadowHeavyTop had a negative Y offset (0 -4px 24px ...) casting the shadow upward, which is correct for bottom-positioned sticky/fixed footers. The replacement theme.shadow.high has a positive Y offset (0px 4px 0px 2px ...) casting the shadow downward. For elements pinned to the bottom of the viewport, a downward shadow is invisible and loses the visual separation cue with the content above.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.
| const Container = styled('div')` | ||
| border: 1px solid ${p => p.theme.tokens.border.primary}; | ||
| box-shadow: inset ${p => p.theme.dropShadowMedium}; | ||
| box-shadow: inset ${p => p.theme.shadow.medium}; |
There was a problem hiding this comment.
Inset keyword only applies to first shadow value
Medium Severity
box-shadow: inset ${theme.shadow.medium} prepends inset to a multi-value shadow token. Since shadow.medium expands to two comma-separated shadows, the inset keyword only applies to the first one. The second shadow renders as an external (outset) drop shadow, which differs from the original single inset dropShadowMedium behavior.
Reviewed by Cursor Bugbot for commit 26c4ba8. Configure here.


a bit more theme cleanup! Replacing the ad-hoc
theme.dropShadow*values with our officialtheme.shadow.*tokens.