perf(incidents): Avoid N+1 in WorkflowEngineIncidentSerializer#113009
Merged
perf(incidents): Avoid N+1 in WorkflowEngineIncidentSerializer#113009
Conversation
github-actions
bot
added
the
Scope: Backend
![sentry-warden[bot]](https://avatars.githubusercontent.com/in/2755838?s=60&v=4){kind=small}
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
ceorourke
approved these changes
Apr 15, 2026
Member
ceorourke
left a comment
ceorourke
left a comment
There was a problem hiding this comment.
lgtm though the bot might be onto something
wedamija
approved these changes
Apr 15, 2026
kcons
commented
Apr 15, 2026
| incident_id = get_fake_id_from_object_id(obj.id) | ||
| incident_identifier = incident_id | ||
| incident_id = attrs["incident_id"] | ||
| incident_identifier = attrs["incident_identifier"] |
Member
Author
There was a problem hiding this comment.
Warden's complaint here isn't entirely invalid, but it is no different than the behavior before this change. I think we're ok with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We should be doing our querying in batches in get_attrs, not in serialize.