ref(cmdk): Guard GlobalCommandPaletteActions behind cmd-k-supercharged at the mount site#113021
Merged
Conversation
…ged flag is not enabled Move all hook calls before the feature flag guard to satisfy Rules of Hooks, then early-return null when the organization does not have the cmd-k-supercharged feature. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
Contributor
Sentry Snapshot Testing
|
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8f964c1. Configure here.
Guard GlobalCommandPaletteActions at the mount point in navigation/index.tsx instead of inside the component. This prevents the component from mounting entirely when the flag is off, so hooks like useStarredIssueViews, useGetStarredDashboards, and useProjects never run and no unnecessary API calls are made. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
JonasBa
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Moves the `cmd-k-supercharged` feature flag check from inside `GlobalCommandPaletteActions` to its call site in `navigation/index.tsx`.
When the flag is disabled the component is never mounted, so hooks like `useStarredIssueViews`, `useGetStarredDashboards`, and `useProjects` never run and no unnecessary API calls are made on every page load for orgs without the flag.