ref(tags): use placeholder loader#113025
Conversation
…chemaHintsList Swap the LoadingIndicator for a row of Placeholder skeleton pills that match the shape and layout of the actual tag hint buttons. The loading container uses overflow:hidden so excess pills are clipped cleanly. Co-Authored-By: Claude <noreply@anthropic.com>
github-actions
Bot
added
the
Scope: Frontend
| <Flex justify="center" align="center" height="24px"> | ||
| <LoadingIndicator mini /> | ||
| </Flex> | ||
| <SchemaHintsContainer aria-label={t('Schema Hints List')} style={{overflow: 'hidden'}}> |
There was a problem hiding this comment.
I tried seeing if we can convert to Container or Flex, but this uses > * {flex-shrink: 0}, so I'd rather not touch it
Sentry Snapshot Testing
|
There was a problem hiding this comment.
looks good! I was wondering why we always see the placeholder even when there’s cached data, and I found that we bind isLoading to isFetching, which is true for all fetches, including background refetches:
not sure what the idea behind this is but it feels wrong? Also I had to navigate 5 layers to get to that code so not sure what the impact of changing this one thing would be :/
I'll be doing some refactoring around this, iirc we do want this to stay as |
3 participants
Replace incorrectly used loadingIndicator with Placeholder component