fix(workflows): Don't reuse existing workflow in create_priority_workflow#113133
Merged
fix(workflows): Don't reuse existing workflow in create_priority_workflow#113133
Conversation
saponifi3d
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflows are organization scoped, so there shouldn't be any need to create a new priority error workflow for every project; one should be enough.
However, we're still supporting the APIs/UI for Rule, and Rules were each dual written to Workflows and will soon be represented as Workflows. We can't represent per-project Rules as a single Workflow, and in the cases where we currently do, any modification to the Rule (including delete) results in inconsistency and brokenness.
So, we need to ensure that newly created "rules" aren't deduplicated for now, and in another change we'll process existing shared workflows to unshare them, at least until we're no longer offering a Rule interface.
Part of ISWF-2470.