Skip to content

fix(workflows): Don't reuse existing workflow in create_priority_workflow#113133

Merged
kcons merged 1 commit intomasterfrom
kcons/nosharing
Apr 15, 2026
Merged

fix(workflows): Don't reuse existing workflow in create_priority_workflow#113133
kcons merged 1 commit intomasterfrom
kcons/nosharing

Conversation

@kcons
Copy link
Copy Markdown
Member

@kcons kcons commented Apr 15, 2026

Workflows are organization scoped, so there shouldn't be any need to create a new priority error workflow for every project; one should be enough.

However, we're still supporting the APIs/UI for Rule, and Rules were each dual written to Workflows and will soon be represented as Workflows. We can't represent per-project Rules as a single Workflow, and in the cases where we currently do, any modification to the Rule (including delete) results in inconsistency and brokenness.

So, we need to ensure that newly created "rules" aren't deduplicated for now, and in another change we'll process existing shared workflows to unshare them, at least until we're no longer offering a Rule interface.

Part of ISWF-2470.

@kcons kcons requested a review from a team as a code owner April 15, 2026 23:07
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 15, 2026
@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 15, 2026

@kcons kcons merged commit f5e6ec5 into master Apr 15, 2026
61 checks passed
@kcons kcons deleted the kcons/nosharing branch April 15, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants