Skip to content

ref(cmdk): Add missing secondary nav items to command palette#113155

Open
JonasBa wants to merge 2 commits intomasterfrom
jb/ref/cmdk-add-missing-nav
Open

ref(cmdk): Add missing secondary nav items to command palette#113155
JonasBa wants to merge 2 commits intomasterfrom
jb/ref/cmdk-add-missing-nav

Conversation

@JonasBa
Copy link
Copy Markdown
Member

@JonasBa JonasBa commented Apr 16, 2026

Audited the secondary navigation sections against the CMDK Go to... menu and found a number of pages present in the sidebar that were not reachable from the command palette.

Issues

  • Instrumentation (seer-autopilot flag)
  • Autofix > Recently Run (seer-issue-view flag)

Explore

  • Metrics (tracemetrics-enabled flag + platform support check, matching sidebar logic)
  • Errors (organizations:explore-errors flag)
  • Conversations (gen-ai-conversations flag)
  • Starred Queries (dynamic, up to 20, matching sidebar cap)

Dashboards

  • Sentry Built (dashboards-prebuilt-insights-dashboards flag)

Monitors (was only Crons + Uptime)

  • All Monitors
  • My Monitors
  • Errors, Metrics (monitor types)
  • Mobile Builds (organizations:preprod-size-monitors-frontend flag)
  • Alerts

Projects (new section, was entirely absent)

  • All Projects (via makeProjectsPathname, respects insights-to-dashboards-ui-rollout)
  • Bookmarked projects (up to 8, matching sidebar behaviour)

All feature flags and platform checks mirror their secondary nav counterparts exactly.

Fixes DE-1059

@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 16, 2026
@JonasBa JonasBa marked this pull request as ready for review April 16, 2026 11:37
@JonasBa JonasBa requested a review from a team as a code owner April 16, 2026 11:37
Comment thread static/app/components/commandPalette/ui/commandPaletteGlobalActions.tsx Outdated
Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit c281b1a4f6fbefd7d55d58c0c605857116e5f545. Configure here.

Audit secondary navigation sections and add items that were present
in the sidebar but missing from the CMDK Go to... menu:

- Issues: Instrumentation (seer-autopilot), Autofix > Recently Run (seer-issue-view)
- Explore: Metrics (tracemetrics-enabled + platform check), Errors
  (explore-errors), Conversations (gen-ai-conversations), Starred Queries
- Dashboards: Sentry Built (dashboards-prebuilt-insights-dashboards)
- Monitors: All Monitors, My Monitors, Errors, Metrics, Mobile Builds
  (preprod-size-monitors-frontend), Alerts
- Projects: new section with All Projects and bookmarked projects

Co-Authored-By: Claude <noreply@anthropic.com>
@cursor cursor bot force-pushed the jb/ref/cmdk-add-missing-nav branch from 4ed28f9 to 4c7a96e Compare April 16, 2026 13:54
Starred saved queries were linking to /explore/saved-queries/{id}/ which
doesn't exist as a route. The sidebar correctly uses getSavedQueryTraceItemUrl
to generate dataset-specific URLs (e.g., /explore/traces/?id=...). Now the
command palette uses the same logic to ensure queries link to valid routes.

Co-authored-by: Jonas <JonasBa@users.noreply.github.com>

{hasWorkflowEngineUI && (
<CMDKAction display={{label: t('Monitors'), icon: <IconSiren />}}>
<CMDKAction display={{label: t('All Monitors')}} to={`${prefix}/monitors/`} />
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably a future add, but might be good to make these more dynamic, like what we currently have for nested project settings with getUserOrgNavigationConfiguration. Would remove the need to explicitly add these when those nav items change.

Generally too and more long term, I'd wonder if we could have cmdk leverage routes.tsx to automatically add available nav items to search?

@JonasBa
Copy link
Copy Markdown
Member Author

JonasBa commented Apr 18, 2026

Fixes DE-1059

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 18, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants