ref(cmdk): Add missing secondary nav items to command palette#113155
ref(cmdk): Add missing secondary nav items to command palette#113155
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit c281b1a4f6fbefd7d55d58c0c605857116e5f545. Configure here.
Audit secondary navigation sections and add items that were present in the sidebar but missing from the CMDK Go to... menu: - Issues: Instrumentation (seer-autopilot), Autofix > Recently Run (seer-issue-view) - Explore: Metrics (tracemetrics-enabled + platform check), Errors (explore-errors), Conversations (gen-ai-conversations), Starred Queries - Dashboards: Sentry Built (dashboards-prebuilt-insights-dashboards) - Monitors: All Monitors, My Monitors, Errors, Metrics, Mobile Builds (preprod-size-monitors-frontend), Alerts - Projects: new section with All Projects and bookmarked projects Co-Authored-By: Claude <noreply@anthropic.com>
4ed28f9 to
4c7a96e
Compare
Starred saved queries were linking to /explore/saved-queries/{id}/ which
doesn't exist as a route. The sidebar correctly uses getSavedQueryTraceItemUrl
to generate dataset-specific URLs (e.g., /explore/traces/?id=...). Now the
command palette uses the same logic to ensure queries link to valid routes.
Co-authored-by: Jonas <JonasBa@users.noreply.github.com>
4c7a96e to
1779564
Compare
|
|
||
| {hasWorkflowEngineUI && ( | ||
| <CMDKAction display={{label: t('Monitors'), icon: <IconSiren />}}> | ||
| <CMDKAction display={{label: t('All Monitors')}} to={`${prefix}/monitors/`} /> |
There was a problem hiding this comment.
Probably a future add, but might be good to make these more dynamic, like what we currently have for nested project settings with getUserOrgNavigationConfiguration. Would remove the need to explicitly add these when those nav items change.
Generally too and more long term, I'd wonder if we could have cmdk leverage routes.tsx to automatically add available nav items to search?
|
Fixes DE-1059 |

Audited the secondary navigation sections against the CMDK Go to... menu and found a number of pages present in the sidebar that were not reachable from the command palette.
Issues
seer-autopilotflag)seer-issue-viewflag)Explore
tracemetrics-enabledflag + platform support check, matching sidebar logic)organizations:explore-errorsflag)gen-ai-conversationsflag)Dashboards
dashboards-prebuilt-insights-dashboardsflag)Monitors (was only Crons + Uptime)
organizations:preprod-size-monitors-frontendflag)Projects (new section, was entirely absent)
makeProjectsPathname, respectsinsights-to-dashboards-ui-rollout)All feature flags and platform checks mirror their secondary nav counterparts exactly.
Fixes DE-1059