fix(trace): Fix span bars rendering too far to the right when scrollbar is visible#113166
Open
nsdeschenes wants to merge 3 commits intomasterfrom
Open
fix(trace): Fix span bars rendering too far to the right when scrollbar is visible#113166nsdeschenes wants to merge 3 commits intomasterfrom
nsdeschenes wants to merge 3 commits intomasterfrom
Conversation
Make scrollbar_width public so external listeners can subtract it from container width calculations. Re-dispatch 'set container physical space' whenever the scrollbar width is updated, triggering downstream listeners to recompute trace_physical_space with the correct narrowed width. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ations When a vertical scrollbar is visible, the scroll container rows are narrower than the outer container measured by ResizeObserver. Without accounting for the scrollbar width, trace_physical_space is computed against a wider area than the actual renderable column, causing span bars to render shifted to the right. Subtract scrollbar_width from the container width in both the onPhysicalSpaceChange listener (useTraceSpaceListeners) and the column layout handler (virtualizedViewManager) so the physical space always matches the visible column width. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 960f64a. Configure here.
… change When the scrollbar width changes, re-dispatch the container physical space using the content box (excluding padding and border) instead of the full bounding client rect. This matches the box model that ResizeObserver uses for contentRect, preventing bars from being positioned relative to a wider space than the actual content area. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a vertical scrollbar is visible in the trace waterfall, span bars were rendered too far to the right. There were two related issues:
useTraceSpaceListenerscomputedtrace_physical_spacefrom the full outer container width without subtracting the scrollbar width, so the renderable span column was wider than the actual visible area.onScrollbarWidthChangefired, it updatedscrollbar_widthbut didn't trigger a recalculation of the container physical space — so the first issue wasn't corrected until the nextResizeObserverevent.The fix subtracts
scrollbar_widthfrom the container width inuseTraceSpaceListeners, and re-dispatches the container content-box dimensions (matchingResizeObserver'scontentRect) whenever the scrollbar width changes.Closes EXP-878