Conversation
Comment on lines
+108
to
111
| "DELETE": "organizations:workflow-engine-issue-alert-endpoints-delete", | ||
| } | ||
| publish_status = { | ||
| "DELETE": ApiPublishStatus.PUBLIC, |
Contributor
There was a problem hiding this comment.
Bug: An unexpected error during Rule deletion can cause an inconsistent state because the associated Workflow deletion is committed separately and cannot be rolled back.
Severity: MEDIUM
Suggested Fix
Wrap both the Workflow and Rule deletion operations within a single, overarching atomic transaction. This ensures that both operations must succeed for the changes to be committed, preventing any potential for an inconsistent state if the Rule deletion fails unexpectedly.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: src/sentry/api/endpoints/project_rule_details.py#L108-L111
Potential issue: In the `delete` method, a `Workflow` is scheduled for deletion and this
change is committed within its own atomic transaction. Subsequently, the code attempts
to delete the associated `Rule`. However, the error handling for the `Rule` deletion
only catches `DoesNotExist` exceptions. If any other unexpected exception occurs during
the `Rule` deletion, the API will return a 500 error, leaving the system in an
inconsistent state where the `Workflow` is pending deletion but the `Rule` is not.
Did we get this right? 👍 / 👎 to inform future reviews.
ceorourke
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.