feat(tracemetrics): Add parser for resolved expressions#113230
Open
narsaynorath wants to merge 1 commit intomasterfrom
Open
feat(tracemetrics): Add parser for resolved expressions#113230narsaynorath wants to merge 1 commit intomasterfrom
narsaynorath wants to merge 1 commit intomasterfrom
Conversation
github-actions
bot
added
the
Scope: Frontend
narsaynorath
force-pushed
the
nar/feat/tracemetrics-alert-equations-add-parser-for-resolved-expressions
branch
from
51da647 to
f75409d
Compare
github-actions
bot
added
the
Scope: Backend
Contributor
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
narsaynorath
changed the base branch from
nar/ref/tracemetrics-equations-extract-state-keeping-from-state-changes
to
master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parser helper that will take a resolved equation, and break out the smaller sub-components needed to compose the original equation.
This gets around the issue of alerts only storing the single aggregate it's alerting on. In the equation case it'll be the full equation, so for the UI to continue using references we need to parse the equation and get the subcomponents to initialize some local state.
You don't really need to review the
MetricsEquationVisualize, I just wanted to add it to mock out a spot where I think the new UI we're building for equations will live. It mostly just validates the idea of parsing an equation from something I've saved here: https://sentry.dev.getsentry.net:7999/monitors/7037172/edit/ . It also prevents knip from complaining without having to add a line to ignore knip for this helperYou can also test it here: https://sentry-gx0w9jqhi.sentry.dev/monitors/7037172/edit/
and enable the
tracemetrics-equations-in-alertsflag