Conversation
shashjar
commented
Apr 16, 2026
|
|
||
| if event.group_id: | ||
| if options.get("eventstore.adjacent_event_ids_use_snql"): | ||
| prev_ids, next_ids = eventstore.backend.get_adjacent_event_ids_snql( |
Member
Author
There was a problem hiding this comment.
In the future we should migrate fully to this other read path, but I believe there are some bugs to work out before this query works as expected. So this PR just fixes the legacy query (which is used everywhere right now) as a fix in the meantime.
scttcper
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ID-1257.
The Next/Prev event buttons on the issue details page currently ignore the search query applied on the issue feed, so users walking events end up on ones that don't match their filter. First, latest, and initial-load event all already work.
This PR updates the query path used by next/prev event navigation to ensure that the user's filters/conditions are applied. This new behavior is behind an organization allowlist so I can test in the Sentry org before rolling out fully.