fix(seer): Support cmd+click to open Explorer tool links in new tab#113242
fix(seer): Support cmd+click to open Explorer tool links in new tab#113242
Conversation
github-actions
bot
added
the
Scope: Frontend
trevor-e
force-pushed
the
telkins/fix/explorer-tool-link-cmd-click
branch
from
695c7dc to
cdd42c1
Compare
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit cdd42c1. Configure here.
| ? to | ||
| : `${to.pathname ?? ''}${to.search ?? ''}${to.hash ?? ''}`; | ||
| window.open(path, '_blank', 'noopener,noreferrer'); | ||
| return; |
There was a problem hiding this comment.
Cmd+click navigation skips analytics tracking
Low Severity
The new cmd/ctrl+click code path calls window.open directly and returns early, completely bypassing navigateToToolLink. That helper exists specifically to bundle navigation with trackAnalytics (as its comment states: "Tool link navigation, with analytics and onNavigate hook"). All cmd+click navigations to tool links will therefore be silently absent from the seer.explorer.global_panel.tool_link_navigation analytics event, underreporting actual tool-link usage.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit cdd42c1. Configure here.
Tool call links in the Explorer chat used onClick handlers on a
<button>, so cmd+click had no effect. Now cmd+click / ctrl+click
opens the link in a new tab via window.open.
Also fixes tool link URLs missing the /organizations/{slug}/ prefix,
which caused broken navigation on local dev (and non-customer-domain
deployments).
trevor-e
force-pushed
the
telkins/fix/explorer-tool-link-cmd-click
branch
from
cdd42c1 to
2329f34
Compare
1 participant
Tool call links in the Explorer chat (e.g. "Inspected issue PROJ-123") were rendered as
<button>elements withonClickhandlers, so cmd+click / ctrl+click had no effect — you could only navigate in the current tab.Changed
ToolCallLinkfromstyled('button')tostyled('a')with a computedhref. Plain clicks still use client-side navigation via React Router; cmd+click and ctrl+click now fall through to the browser's native new-tab behavior.