feat(seer): Move the advanced seer settings to their own page#113248
feat(seer): Move the advanced seer settings to their own page#113248
Conversation
github-actions
bot
added
the
Scope: Frontend
![sentry[bot]](https://avatars.githubusercontent.com/in/12637?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| defaultCodeReviewTriggers: z.array(z.enum(['on_new_commit', 'on_ready_for_review'])), | ||
| enableSeerEnhancedAlerts: z.boolean(), | ||
| enableSeerCoding: z.boolean(), | ||
| }); | ||
|
|
||
| export function SeerAutomationSettings() { | ||
| const organization = useOrganization(); | ||
| const canWrite = useCanWriteSettings(); | ||
|
|
||
| const showSeerOverview = organization.features.includes('seer-overview'); | ||
|
|
||
| const scmOverviewData = useSCMOverviewSection(); | ||
| const autofixOverviewData = useAutofixOverviewData(); | ||
| const codeReviewOverviewData = useCodeReviewOverviewSection(); | ||
|
|
||
| const orgEndpoint = `/organizations/${organization.slug}/`; | ||
| const orgMutationOpts = mutationOptions({ |
There was a problem hiding this comment.
Bug: Orphaned test and story files import deleted components, which will cause build and test failures.
Severity: HIGH
Suggested Fix
Delete the orphaned files autofixOverviewSection.spec.tsx and autofixOverviewSection.stories.tsx since their corresponding components have been removed. Consider also removing the seer-overview feature flag from the backend to eliminate dead code.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/gsApp/views/seerAutomation/settings.tsx#L30-L42
Potential issue: The pull request removes frontend components and logic for the
`seer-overview` feature, such as `autofixOverviewSection.tsx`. However, it fails to
remove the associated test file (`autofixOverviewSection.spec.tsx`) and story file
(`autofixOverviewSection.stories.tsx`). These files still contain import statements for
the deleted components. This will lead to import resolution errors, causing the build
process or test suite to fail. Additionally, the `seer-overview` feature flag still
exists in the backend, but the frontend no longer has code to handle it, rendering the
flag ineffective.
Also affects:
autofixOverviewSection.spec.tsxautofixOverviewSection.stories.tsx
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit eedea25. Configure here.
| )} | ||
| </AutoSaveForm> | ||
| </FieldGroup> | ||
| } |
There was a problem hiding this comment.
Unnecessary expression wrapper left from ternary removal
Low Severity
After removing the showSeerOverview ternary, the { and } wrapping the <Fragment> were left behind as an artifact. The {<Fragment>...</Fragment>} is functionally identical to just <Fragment>...</Fragment> — the curly braces serve no purpose without the ternary expression and add unnecessary noise.
Reviewed by Cursor Bugbot for commit eedea25. Configure here.
| [t('Repositories'), '/seer/scm/'], | ||
| [t('Autofix'), '/seer/projects/'], | ||
| [t('Code Review'), '/seer/repos/'], | ||
| [t('Advanced Settings'), '/seer/advanced/'], | ||
| ] | ||
| : [ | ||
| [t('Autofix'), '/seer/'], |
There was a problem hiding this comment.
Bug: Legacy Seer users can access the "Advanced Settings" page via new deep links, but the corresponding navigation tab is hidden for them, creating a confusing UX.
Severity: LOW
Suggested Fix
The visibility of the deep links should be synchronized with the visibility of the "Advanced Settings" navigation tab. Either show the tab to all users who can see the links, or hide the links from users who cannot see the tab by gating them with the same showNewSeer(organization) condition.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent. Verify if this is a real issue. If it is, propose a fix; if not, explain why it's
not valid.
Location: static/gsApp/views/seerAutomation/components/settingsPageTabs.tsx#L19-L25
Potential issue: The "Advanced Settings" tab is conditionally displayed based on the
`showNewSeer(organization)` function, which is true for new Seer plans. However, deep
links to the advanced settings page (`/seer/advanced/#enableSeerCoding`) are shown
unconditionally to all users, including legacy users (e.g., those with `seer-added` or
`code-review-beta` features). When a legacy user clicks one of these links, they are
navigated to a page that is not present in their navigation tabs, creating a confusing
and orphaned page experience.
Also affects:
static/app/components/events/autofix/autofixSolution.tsx:655~661static/app/components/events/autofix/autofixStartBox.tsx:68~76static/app/components/events/autofix/v2/nextSteps.tsx:195~203static/gsApp/views/seerAutomation/components/projectDetails/agentSettings/seerAgentSettings.tsx:55~63
<!-- Use this checklist to make sure your PR is ready for merge. You may delete any sections you don't need. --> ## DESCRIBE YOUR PR Keeping links to specific settings in sync with where those settings live. Depends on getsentry/sentry#113248 ## IS YOUR CHANGE URGENT? Help us prioritize incoming PRs by letting us know when the change needs to go live. - [ ] Urgent deadline (GA date, etc.): <!-- ENTER DATE HERE --> - [ ] Other deadline: <!-- ENTER DATE HERE --> - [x] None: Not urgent, can wait up to 1 week+ ## SLA - Teamwork makes the dream work, so please add a reviewer to your PRs. - Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it. Thanks in advance for your help! ## PRE-MERGE CHECKLIST *Make sure you've checked the following before merging your changes:* - [ ] Checked Vercel preview for correctness, including links - [x] PR was reviewed and approved by any necessary SMEs (subject matter experts) - [ ] PR was reviewed and approved by a member of the [Sentry docs team](https://github.com/orgs/getsentry/teams/docs) ## EXTRA RESOURCES - [Sentry Docs contributor guide](https://docs.sentry.io/contributing/)
2 participants
Relates to getsentry/sentry-docs#17382