Skip to content

fix(dashboards): Align embedded insights alerts#113271

Open
priscilawebdev wants to merge 5 commits intomasterfrom
priscilawebdev/style/insights-banner-alignment
Open

fix(dashboards): Align embedded insights alerts#113271
priscilawebdev wants to merge 5 commits intomasterfrom
priscilawebdev/style/insights-banner-alignment

Conversation

@priscilawebdev
Copy link
Copy Markdown
Member

@priscilawebdev priscilawebdev commented Apr 17, 2026

Render prebuilt dashboard alerts inside DashboardDetail instead of positioning them with standalone padding in PrebuiltDashboardRenderer.

This keeps the Insights migration banner aligned with the embedded dashboard filter bar and surrounding page content anywhere the shared renderer is used.

Co-Authored-By: Codex <codex@openai.com>
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Apr 17, 2026
@priscilawebdev
Copy link
Copy Markdown
Member Author

bugbot run

Copy link
Copy Markdown
Contributor

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit a83baa6. Configure here.

@linear-code
Copy link
Copy Markdown

linear-code bot commented Apr 17, 2026

@priscilawebdev priscilawebdev requested a review from a team April 17, 2026 11:40
@priscilawebdev priscilawebdev marked this pull request as ready for review April 17, 2026 12:00
@priscilawebdev priscilawebdev requested a review from a team as a code owner April 17, 2026 12:00
Copy link
Copy Markdown
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, thanks, though these pages are going to be completely deleted in the next week or so!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants